Skip to content

Added @synchronized decorator to provide thread-based locking support for ssl cert creation#1821

Merged
whummer merged 2 commits intolocalstack:masterfrom
shawnrusaw-wf:issue_1811
Dec 2, 2019
Merged

Added @synchronized decorator to provide thread-based locking support for ssl cert creation#1821
whummer merged 2 commits intolocalstack:masterfrom
shawnrusaw-wf:issue_1811

Conversation

@shawnrusaw-wf
Copy link
Contributor

@shawnrusaw-wf shawnrusaw-wf commented Dec 2, 2019

Proposed fix for Issue #1811.

  1. Adds @synchronized decorator to provide thread-based locking support
  2. Added @synchronized around common.generate_ssl_cert
  • Add tests for any new features and bug fixes. Ideally, each PR should increase the test coverage.
  • Follow the existing code style (e.g., indents). A PEP8 code linting target is included in the Makefile.
  • Put a reasonable amount of comments into the code.
  • Separate unrelated changes into multiple pull requests.
  • 1 commit per PR: Please squash/rebase multiple commits into one single commit (to keep the history clean).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 51.695% when pulling 96cb589 on shawnrusaw-wf:issue_1811 into 41b37c2 on localstack:master.

@whummer whummer merged commit caad616 into localstack:master Dec 2, 2019
@whummer
Copy link
Member

whummer commented Dec 2, 2019

Awesome, thanks @shawnrusaw-wf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants