Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit d769b53

Browse files
anisaoshafianisaoshafi
committed
Address suggestions
1 parent 8f1df6d commit d769b53

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎localstack-core/localstack/services/lambda_/runtimes.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@
176176
VALID_RUNTIMES: str = "[nodejs20.x, python3.14, provided.al2023, python3.12, python3.13, nodejs24.x, nodejs22.x, java25, python3.10, python3.11, java21, ruby3.3, ruby3.4, ruby3.2, python3.8, python3.9, java17, nodejs16.x, dotnet10, dotnet8, java11, dotnet6, nodejs18.x, provided.al2, java8.al2]"
177177
# An ordered list of all Lambda runtimes for layers considered valid by AWS. Matching snapshots in test_layer_exceptions
178178
VALID_LAYER_RUNTIMES: str = "[ruby3.5, ruby2.6, dotnetcore1.0, python3.7, nodejs8.10, nasa, ruby2.7, python2.7-greengrass, dotnetcore2.0, python3.8, java21, dotnet6, dotnetcore2.1, python3.9, java11, nodejs6.10, provided, dotnetcore3.1, dotnet8, java25, java17, nodejs, nodejs4.3, java8.al2, go1.x, dotnet10, nodejs20.x, go1.9, byol, nodejs10.x, provided.al2023, nodejs22.x, python3.10, java8, nodejs12.x, python3.11, nodejs24.x, nodejs8.x, python3.12, nodejs14.x, nodejs8.9, nodejs26.x, python3.13, python3.14, nodejs16.x, python3.15, provided.al2, nodejs4.3-edge, nodejs18.x, ruby3.2, python3.4, ruby3.3, ruby3.4, ruby2.5, python3.6, python2.7]"
179-
179+
# An unordered list of runtimes supporting Lambda Managed Instances: https://docs.aws.amazon.com/lambda/latest/dg/lambda-managed-instances-runtimes.html#lambda-managed-instances-supported-runtimes
180180

181181
VALID_MANAGED_INSTANCE_RUNTIMES = [
182182
Runtime.nodejs24_x,
@@ -187,5 +187,6 @@
187187
Runtime.java21,
188188
Runtime.dotnet10,
189189
Runtime.dotnet8,
190+
# not officially listed, but can be invoked
190191
Runtime.provided_al2023,
191192
]

‎localstack-core/localstack/testing/aws/lambda_utils.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,8 @@ def _create_function():
220220
self.function_names.append(result["FunctionArn"])
221221

222222
def _is_not_pending():
223+
# Using custom wait condition instead of the 'function_active_v2' waiter which expects 'Active' state,
224+
# which is not true for lambda managed instances, whose state becomes in ActiveNonInvokable
223225
try:
224226
result = (
225227
self.lambda_client.get_function(FunctionName=kwargs.get("FunctionName"))[

0 commit comments

Comments
 (0)