service.dnsService also exposes DNS port of the kubernetes Service#120
Merged
alexrashed merged 2 commits intolocalstack:mainfrom May 17, 2024
Merged
Conversation
services.dnsService also exposes DNS port of the kubernetes Serviceservice.dnsService also exposes DNS port of the kubernetes Service
alexrashed
requested changes
May 16, 2024
Member
alexrashed
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution!
Unfortunately, the addition you added does not create a valid service manifest.
Let me know if you need help with the fix, and please make sure to test your changes on your side. We need to make sure that we don't break the chart for users who already have the dns service enabled.
I can recomment using kind to create a cluster locally for testing:
kind create cluster --name ls-demo
helm install ls-helm-demo ./charts/localstack/ -f charts/localstack/test-values.yaml
alexrashed
approved these changes
May 17, 2024
Member
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot for addressing the comments and thanks a lot for the contribution in general! 🚀
I'll go ahead and directly merge and release this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #109
Motivation
Enabling
service.dnsServicedoesn't actually expose the dns service in a way that is usable outside of port-forwarding.Exposing the DNS port at the service level allows it to be used alongside clusterIP for DNS delegation with kube-dns or coredns.
Changes
Adds service-to-pod routing of port 53 for both TCP and UDP connections