This repository was archived by the owner on Aug 7, 2025. It is now read-only.
add all internal-tested operations as implemented #539
Merged
Conversation
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-539.surge.sh 🎊 |
alexrashed
approved these changes
Mar 28, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
LGTM! 🚀 We should take a closer look at why the test data differs from the previous pipeline right after the v2 release.
Contributor
For S3, I'm currently fixing it, it was a patch that hadn't been migrated. It's the coverage docs helped us realise that!! Thanks again @steffyP 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR marks operations as implemented, that are tested internally, but have been classified as "not implemented" before.
@bentsku made me aware, that some operations sometimes return a 501, even if implemented (and tested), see localstack/localstack#7981. In this special case the root cause is moto, which explicitly raises
NotImplementedErrorif some special parameters are used.While running the script locally, I realized that some operations of services that are extended in pro, also seem to be wrongly classified now. Need to be further investigated.