Mockturtle irc bot port to ruby #1637
Conversation
| @db = db | ||
| end | ||
|
|
||
| def watch_github |
There was a problem hiding this comment.
Need to fix persistence so we can actually start scraping stories.
Should probably fail open and set lastSeen as a class variable. So even if we don't have working persistence we can still scrape rss.
There was a problem hiding this comment.
Yeah. We should use ActiveRecord here. For all I grumble about it, the consistency of matching the site database access would be worth it.
pushcx
left a comment
There was a problem hiding this comment.
Off to a good start here, and I've seen the activity in the test channel. I've added some Ruby pointers and I look forward to seeing this in prod. I'll talk to you offline about that idea of setting up some pairing time.
mockturtle/README.md
Outdated
| ## License | ||
| ``` | ||
| Copyright 2025 Noah Hendrickson |
There was a problem hiding this comment.
I'd prefer to use the license that's already used for the site (3 clause BSD, if my quick glance is correct) because code will be shared between the bot and site. Do you have a strong preference that we do it differently?
There was a problem hiding this comment.
No strong preference, will copy.
There was a problem hiding this comment.
If we're using the same license, you can probably just delete the license from this README and the whole repo is covered by the top level license.
| @db = db | ||
| end | ||
|
|
||
| def watch_github |
There was a problem hiding this comment.
Yeah. We should use ActiveRecord here. For all I grumble about it, the consistency of matching the site database access would be worth it.
| require "time" | ||
|
|
||
| class Seen | ||
| class SeenStruct < Struct.new(:who, :where, :time) |
There was a problem hiding this comment.
Since these aren't modified after creation, recent versions of Ruby (which we're running) have a Data class that's immutable.
I'd also prefer to just be Seen without the hungarian notation. Ruby is very timey-wimey about types.
Gemfile
Outdated
| gem "lograge" # for JSON logging | ||
| gem "silencer" # to disable default logging in prod | ||
|
|
||
| # mockturtle |
There was a problem hiding this comment.
Because this is going to run in a separate process, let's make a mockturtle/Gemfile for it. I don't want the Rails processes to take up any more RAM than they already do.
Gemfile
Outdated
| gem "ircinch" | ||
| gem "json" | ||
| gem "nokogiri" | ||
| gem "open-uri" |
There was a problem hiding this comment.
Please remove this and use extras/sponge.rb to fetch anything. It prevents people from saying in chat "https://127.0.0.1:22" etc and using the bot to portscan/exploit us or others.
Gemfile
Outdated
| gem "open-uri" | ||
| gem "rss" | ||
| gem "sqlite3" | ||
| gem "time" |
There was a problem hiding this comment.
Not needed, it's in the standard library and loaded automatically.
There was a problem hiding this comment.
We don't need it in the Gemfile, we do need to require it (which we might be getting for free with the Gemfile entry?)
Methods like Time.parse() aren't loaded unless you explicitly require the time stdlib.
|
Open integration questions for myself:
|
We should be able to configure ActiveRecord readonly connections, the safest way would be to have a readonly Postgres user the bot connects as.
The bot could listen on a local port or socket, and have the app make a request in the background to the bot over localhost to trigger it? |
eccd0ea to
e42d35b
Compare
| gem "ircinch" | ||
| gem "rss" | ||
|
|
||
| # performance monitoring |
There was a problem hiding this comment.
| # performance monitoring | |
| # bug reporting |
|
Building on @caius's comment, I think we could cheaply get a robust way for the rails app to boss the irc bot around by using Solid Queue. The rails app could write jobs to the queue for a worker process in the mockturtle process to run. This saves us writing our own code for things like serialization or supervising the worker. Solid Queue includes a puma plugin for that process to supervise a solid queue worker, and I think this is very close to what we'd want. So maybe we get something very mature very cheaply! |
|
This PR has had no activity for 21 days. Please leave a comment or commit to indicate you're still actively working on it. |
|
This PR has had no activity for 21 days. Please leave a comment or commit to indicate you're still actively working on it. |
|
This PR was closed because it was open for 28 days with no activity. Please reopen when you'd like to continue work on this. |
Basic port of the current mockturtle nodeJS codebase to a ruby port under the main lobsters repo.
Implements the same dot commands mockturtle currently does as well as the rss watching notifications we already have for new site stories and repo commits.
Still needs: