💄 style: Optimized model list & search by sxjeru · Pull Request #9397 · lobehub/lobehub

sxjeru · 2025-09-24T02:15:15Z

🧹 chore(SearchResult): remove debug log for filtered models

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

搜索结果更换为虚拟列表，将卡顿转化为更能接受的列表空白加载（为每次键入自动搜索做准备）
每次输入时自动搜索，类似搜索提供商效果（是否需要？空白加载在 1s 内）
进一步可将初始模型列表也更换为虚拟列表
上下滚动时可能存在抖动（暂无解决方案）
模型搜索框，当点击外部使其失焦时，自动执行一次搜索，使操作人性化。
更换其他提供商时，复原搜索框状态

进一步可以考虑当输入内容大于 n 个字符，每次输入自动执行搜索。需权衡搜索的卡顿问题。

📝 补充信息 | Additional Information

Summary by Sourcery

Optimize the search input component by managing its value in local state, firing searches on blur when the value changes, and cleaning up debug logs.

Enhancements:

Make the search input a controlled component synced to prop value
Trigger searches automatically on input blur when the text has changed while preserving manual search triggers
Retain manual search via Enter key or search icon

Chores:

Remove console.log debug statement from SearchResult

🧹 chore(SearchResult): remove debug log for filtered models

vercel · 2025-09-24T02:15:20Z

@sxjeru is attempting to deploy a commit to the LobeHub OSS Team on Vercel.

A member of the Team first needs to authorize it.

sourcery-ai · 2025-09-24T02:15:21Z

Reviewer's Guide

Converted the search input to a controlled component with local state and onBlur-triggered searches for a more user-friendly behavior, and cleaned up a leftover debug log in the search results.

File-Level Changes

Change	Details	Files
Convert search input to controlled component with local state	Introduced `text` state and `useEffect` to sync with `value` prop Replaced `defaultValue` with controlled `value` prop Updated `onChange` to only update local state Added `onBlur` handler to trigger search when focus is lost Enhanced `onSearch` to sync state and propagate the search	`src/app/[variants]/(main)/settings/provider/features/ModelList/ModelTitle/Search.tsx`
Remove debug log in search results	Deleted `console.log` call for `filteredModels`	`src/app/[variants]/(main)/settings/provider/features/ModelList/SearchResult.tsx`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gru-agent · 2025-09-24T02:15:27Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`6538d1b`	🚫 Skipped	No files need to be tested {"src/app/[variants]/(main)/settings/provider/features/ModelList/ModelTitle/Search.tsx":"File path does not match include patterns.","src/app/[variants]/(main)/settings/provider/features/ModelList/SearchResult.tsx":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

lobehubbot · 2025-09-24T02:15:28Z

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

codecov · 2025-09-24T02:16:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.65%. Comparing base (62097e6) to head (f49fafc).

Additional details and impacted files

@@            Coverage Diff            @@
##             next    #9397     +/-   ##
=========================================
  Coverage   80.65%   80.65%             
=========================================
  Files         970      970             
  Lines       65922    65922             
  Branches     8705    10141   +1436     
=========================================
  Hits        53171    53171             
  Misses      12751    12751

Flag	Coverage Δ
app	`73.00% <100.00%> (ø)`
database	`98.43% <ø> (ø)`
packages/agent-runtime	`98.08% <ø> (ø)`
packages/context-engine	`91.61% <ø> (ø)`
packages/conversation-flow	`98.05% <ø> (ø)`
packages/electron-server-ipc	`93.76% <ø> (ø)`
packages/file-loaders	`92.21% <ø> (ø)`
packages/model-bank	`100.00% <ø> (ø)`
packages/model-runtime	`91.66% <100.00%> (ø)`
packages/prompts	`79.17% <ø> (ø)`
packages/python-interpreter	`96.50% <ø> (ø)`
packages/utils	`95.31% <ø> (ø)`
packages/web-crawler	`96.81% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`73.16% <ø> (ø)`
Services	`54.54% <ø> (ø)`
Server	`75.29% <ø> (ø)`
Libs	`38.40% <ø> (ø)`
Utils	`83.36% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… and remove unused created field

…ring of search results

…mance and update model filtering logic

…y prop to Search component (更换其他提供商时，复原搜索框状态)

… SearchResult components

…with enabled prop

✨ feat(ollama): 添加 Kimi K2 模型及其配置 🔧 fix(vercelAIGateway): 调整缓存读取费率 🔧 fix(nvidia): 更新 Nvidia 名称为 'Nvidia NIM'

…jeru/9397

arvinxx · 2025-11-06T02:05:36Z

@sxjeru Need to rebase now

This comment was translated by Claude.

Original Content

@sxjeru 得 rebase 下了

Copilot

Pull request overview

This PR optimizes the model list and search functionality by introducing virtual scrolling and improving search UX. The changes address performance issues with large model lists by converting to a virtual list implementation using react-virtuoso, and enhance the search experience by triggering searches on blur in addition to explicit user actions.

Key changes:

Implemented virtual scrolling for both search results and disabled model lists to improve rendering performance
Made search input a controlled component that triggers searches on blur when the value changes, in addition to manual triggers
Removed debug console.log statement from SearchResult component

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/app/[variants]/(main)/settings/provider/features/ModelList/SearchResult.tsx`	Replaced manual filtering with inline logic, removed debug log, integrated virtual list (react-virtuoso) for search results
`src/app/[variants]/(main)/settings/provider/features/ModelList/DisabledModels.tsx`	Added virtual list implementation for disabled models
`src/app/[variants]/(main)/settings/provider/features/ModelList/useModelListVirtualConfig.ts`	New hook providing device-specific virtual list configuration (item heights, viewport calculations)
`src/app/[variants]/(main)/settings/provider/features/ModelList/ModelTitle/Search.tsx`	Converted to controlled component with local state, added blur handler to trigger search when value changes
`src/app/[variants]/(main)/settings/provider/features/ModelList/ModelTitle/index.tsx`	Added key prop to Search components to reset state when provider changes
`src/app/[variants]/(main)/settings/provider/features/ModelList/index.tsx`	Added useEffect to clear search keyword when switching providers
`src/app/[variants]/(main)/settings/provider/features/ModelList/ModelItem.tsx`	Added useEffect to sync local checked state with enabled prop for proper state updates
`src/server/routers/lambda/config/index.test.ts`	Updated test to use deepseek-r1 instead of llama-3.1-8b model
`src/server/routers/lambda/config/__snapshots__/index.test.ts.snap`	Updated snapshot to match new test model
`src/locales/default/modelProvider.ts`	Fixed spacing in Chinese translation (added space after "发布于")
`src/config/modelProviders/nvidia.ts`	Updated provider name from "Nvidia" to "Nvidia NIM"
`src/config/modelProviders/google.ts`	Removed outdated comment reference
`packages/model-runtime/src/utils/modelParse.ts`	Added 'robotics' keyword to Google model parsing configuration for function call, reasoning, and video capabilities
`packages/model-bank/src/aiModels/google.ts`	Added new Gemini models (Latest variants, Preview versions, Robotics-ER), removed deprecated models (1.5 Flash/Pro 002, 1.5 Flash 8B, LearnLM)
`packages/model-bank/src/aiModels/vertexai.ts`	Removed deprecated Gemini 1.5 Flash 002 and Pro 002 models
`packages/model-bank/src/aiModels/openrouter.ts`	Removed deprecated/free models, updated Auto Router description
`packages/model-bank/src/aiModels/ollama.ts`	Added Kimi K2 model with reasoning and function call capabilities
`packages/model-bank/src/aiModels/higress.ts`	Removed deprecated Gemini 1.0 and 1.5 model variants
`packages/model-bank/src/aiModels/vercelaigateway.ts`	Updated cache read pricing for several models

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

arvinxx · 2026-02-04T06:02:59Z

@sxjeru This PR probably needs to be redone 🥵

This comment was translated by Claude.

Original Content

@sxjeru 这个 PR 估计得重新搞了🥵

gru-agent · 2026-02-04T06:03:05Z

⏳ Processing in progress

✨ feat(Search): implement local state management for search input

6538d1b

🧹 chore(SearchResult): remove debug log for filtered models

dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 24, 2025

dosubot Bot added the 💄 Design Design and style issues label Sep 24, 2025

sourcery-ai Bot reviewed Sep 24, 2025

View reviewed changes

✨ feat(OpenRouter, VercelAIGateway): enhance model display name logic…

e996dc6

… and remove unused created field

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 25, 2025

✨ feat(SearchResult): add "show more" functionality and improve rende…

80d9b50

…ring of search results

sxjeru changed the title ~~💄 style: Optimized search input~~ 💄 style: Optimized model list & search Sep 25, 2025

sxjeru added 3 commits September 25, 2025 09:57

Merge branch 'main' into 9.24

1c6b6f1

✨ feat(SearchResult): implement virtual scrolling for improved perfor…

a037544

…mance and update model filtering logic

✨ feat(ModelList): reset search keyword on provider change and add ke…

b28bf51

…y prop to Search component (更换其他提供商时，复原搜索框状态)

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 25, 2025

sxjeru added 8 commits September 25, 2025 10:48

✨ feat(ModelList): implement virtual scrolling for DisabledModels and…

c88194a

… SearchResult components

Remove overscan

e5db255

✨ feat(ModelItem): (全部启用) add useEffect to synchronize checked state …

20f9ba9

…with enabled prop

✨ feat(google): 添加多个 Gemini 模型及其配置

0f14c56

✨ feat(ollama): 添加 Kimi K2 模型及其配置 🔧 fix(vercelAIGateway): 调整缓存读取费率 🔧 fix(nvidia): 更新 Nvidia 名称为 'Nvidia NIM'

✨ feat(OpenRouter): 更新模型描述和上下文窗口大小，移除不必要的模型

decc247

fix test

a11f56f

✨ feat(models): 移除停止服务的 Gemini 1.5

b843b1b

Merge branch '9.24' of https://github.com/sxjeru/lobe-chat into pr/sx…

9cd9afc

…jeru/9397

dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 28, 2025

✨ feat(google): 移除 LearnLM 1.5 Pro Experimental

b57c8f8

vercel Bot deployed to Preview – lobe-chat-preview October 14, 2025 05:49 View deployment

arvinxx changed the base branch from main to next November 6, 2025 02:05

sxjeru force-pushed the 9.24 branch from c118feb to 20a6c2d Compare November 6, 2025 02:19

Merge branch next into 9.24

243745a

dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 6, 2025

dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 14, 2025

sxjeru force-pushed the 9.24 branch 2 times, most recently from 8201750 to 243745a Compare November 20, 2025 11:26

sxjeru force-pushed the 9.24 branch from b680b34 to 243745a Compare November 20, 2025 13:11

dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 20, 2025

Merge branch 'next' into 9.24

cd0cfe0

sxjeru mentioned this pull request Nov 25, 2025

🐛 fix: Update message selectors in TokenTag component #10421

Closed

12 tasks

Merge branch 'next' into 9.24

938ff1d

Copilot AI review requested due to automatic review settings December 4, 2025 05:12

Copilot started reviewing on behalf of sxjeru December 4, 2025 05:15 View session

Copilot finished reviewing on behalf of sxjeru December 4, 2025 05:18

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Comment thread packages/model-bank/src/aiModels/google.ts Outdated

Comment thread src/app/[variants]/(main)/settings/provider/features/ModelList/useModelListVirtualConfig.ts

Update packages/model-bank/src/aiModels/google.ts

f49fafc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

arvinxx closed this Feb 4, 2026

sxjeru mentioned this pull request Apr 26, 2026

💄 style: interactive improvement of model search #14192

Merged

12 tasks

Uh oh!

Conversation

sxjeru commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

Summary by Sourcery

Uh oh!

vercel Bot commented Sep 24, 2025

Uh oh!

sourcery-ai Bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent Bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Uh oh!

lobehubbot commented Sep 24, 2025

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arvinxx commented Nov 6, 2025 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

arvinxx commented Feb 4, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gru-agent Bot commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sxjeru commented Sep 24, 2025 •

edited

Loading

sourcery-ai Bot commented Sep 24, 2025 •

edited

Loading

gru-agent Bot commented Sep 24, 2025 •

edited

Loading

codecov Bot commented Sep 24, 2025 •

edited

Loading

arvinxx commented Nov 6, 2025 •

edited by lobehubbot

Loading

arvinxx commented Feb 4, 2026 •

edited by lobehubbot

Loading