🐛 fix: type errors in oidc http-adapter test breaking CI lint#15499
Merged
Conversation
Declare the untyped oidc-provider deep import (selective_body.js) and type the mock ctx so type-check passes again. Introduced by #15478.
Contributor
There was a problem hiding this comment.
Sorry @AmAzing129, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #15499 +/- ##
===========================================
- Coverage 88.56% 70.82% -17.75%
===========================================
Files 819 3259 +2440
Lines 91994 321750 +229756
Branches 7682 28450 +20768
===========================================
+ Hits 81476 227877 +146401
- Misses 10336 93691 +83355
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
Introduced by #15478 (merged with a red
Test Databasecheck).🔀 Description of Change
src/libs/oidc-provider/http-adapter.test.ts(added in #15478) fails type-check with two errors, which breaks theLintstep of the Test Database job for every PR since the merge (PR CI runs against the merge result withcanary):Note:
canaryitself still looks green because push runs skip test jobs via the duplicate-run check.Fix:
src/libs/oidc-provider/selective-body.d.tsdeclaring the untypedoidc-providerdeep import (@types/oidc-providerdoesn't cover internallib/paths), modeled on the actual middleware contract inselective_body.js.ctxwith the exportedSelectiveBodyContextand drop the now-redundant inlineascast (which didn't suppress TS7016 anyway).No runtime behavior change — type-only fix.
🧪 How to Test
bunx tsgo --noEmit→ exit 0 (2 errors before this fix)bunx vitest run src/libs/oidc-provider/http-adapter.test.ts→ 3 passedbunx eslinton both files → 0 errorsTested locally
Added/updated tests
No tests needed
📝 Additional Information
The remaining red on recent PRs' Test Web App is a separate issue: the E2E scenario
agent-scroll.feature:19(用户消息应固定在聊天列表顶部, expected ≤150px got 643px) fails in ~75% of runs since 2026-06-04 — needs its own investigation (possible real regression in the pin-to-top behavior).