🐛 fix(agent-documents): render system docs in editor by Innei · Pull Request #15462 · lobehub/lobehub

Innei · 2026-06-04T06:44:39Z

💻 变更类型 | Change Type

🐛 Bug fix

🔀 变更说明 | Description of Change

Keep ordinary agent-created documents as LobeHub system Documents without forcing a .md suffix into the title or visible filename.
Render extensionless agent/document / system document entries with the rich Document Editor instead of the highlight/code editor.
Preserve explicit code/text extensions such as .json and .txt so those files still open in highlight mode.
Share agent document file/category/source constants from @lobechat/const across app, server, and database usage.

🧪 测试 | Testing

bunx vitest run --silent=passed-only src/server/services/agentDocuments/index.test.ts src/server/routers/lambda/__tests__/integration/agentDocumentVfs.integration.test.ts src/server/services/agentDocumentVfs/index.test.ts src/utils/__tests__/documentRenderMode.test.ts
bunx vitest run --silent=passed-only src/features/AgentDocumentsExplorer/types.test.ts src/features/AgentDocumentsExplorer/utils/canDrop.test.ts src/features/AgentDocumentsExplorer/DocumentExplorerTree.test.tsx src/routes/(main)/agent/features/Conversation/WorkingSidebar/ResourcesSection/AgentDocumentsGroup.test.tsx src/store/file/slices/document/action.test.ts
cd packages/database && bunx vitest run --silent=passed-only src/models/agentDocuments/__tests__/agentDocument.test.ts src/models/agentDocuments/__tests__/deriveFields.test.ts
git diff --check

vercel · 2026-06-04T06:44:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lobehub	Ready	Preview, Comment	Jun 4, 2026 6:16pm

sourcery-ai

We've reviewed this pull request using the Sourcery rules engine

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e39ad55bbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T06:48:05Z

+const isEditorDocument = (document: DocumentRenderModeFields): boolean => {
+  if (document.category === 'document') return true;
+  if (document.fileType && EDITOR_DOCUMENT_FILE_TYPES.has(document.fileType)) return true;
+  return !!document.sourceType && EDITOR_DOCUMENT_SOURCE_TYPES.has(document.sourceType);


Don't force code agent files into the rich editor

When an agent/VFS caller writes an explicit code filename such as ./config.json, writeOrdinaryDocument preserves that extension but AgentDocumentModel.create still defaults sourceType to agent; this check returns editor mode before the filename language detection runs. In the portal path I inspected (DocumentBody calls getDocumentRenderMode(documentMeta)), those .json/.txt agent documents will no longer open in the highlight/code editor and saving can route them through the rich markdown editor instead.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-04T06:48:05Z

+      doc.fileType === DOCUMENT_FOLDER_TYPE
+        ? trimmedTitle
+        : trimmedTitle
+          ? ensureDefaultAgentDocumentExtension(buildDocumentFilename(trimmedTitle))


Keep the stored title extensionless on rename

For a title-only rename like New title, this now passes New title.md into AgentDocumentModel.rename, but that model treats the argument as the human title as well as the source for the filename, so it persists documents.title = 'New title.md'. That regresses the existing create behavior, which stores title: 'New title' while using filename: 'New title.md', and causes UI/tool callers that compare against or display title to see an unexpected extension after revalidation.

Useful? React with 👍 / 👎.

Innei · 2026-06-04T06:47:42Z


 export type DocumentRenderMode = { mode: 'editor' } | { language: string; mode: 'highlight' };

+const EDITOR_DOCUMENT_FILE_TYPES = new Set([


Is this hardcoded?

This comment was translated by Claude.

Original Content
这里是硬编码？

Innei · 2026-06-04T06:48:10Z

 } from './headlessEditor';

 const MAX_UNIQUE_FILENAME_ATTEMPTS = 1000;
+const DEFAULT_AGENT_DOCUMENT_EXTENSION = '.md';


Extracted it. This should be reusable with the file tree's new file creation constant.

This comment was translated by Claude.

Original Content

抽了应该可以和 file tree的新建文件复用常量

Innei · 2026-06-04T06:48:42Z


 const LOBE_PATH = './lobe';
 const LOBE_SKILLS_PATH = './lobe/skills';
+const DEFAULT_AGENT_DOCUMENT_EXTENSION = '.md';


Same here

This comment was translated by Claude.

Original Content

这里也是

Innei · 2026-06-04T06:49:06Z

-    const title = newTitle.trim();
+    const trimmedTitle = newTitle.trim();
+    const title =
+      doc.fileType === DOCUMENT_FOLDER_TYPE


Don't use complex nested ternaries.

This comment was translated by Claude.

Original Content
不要复杂嵌套三元

codecov · 2026-06-04T06:51:16Z

Codecov Report

❌ Patch coverage is 79.62963% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.85%. Comparing base (f7c46a3) to head (0eb3f74).
⚠️ Report is 2 commits behind head on canary.

Additional details and impacted files

@@             Coverage Diff             @@
##           canary   #15462       +/-   ##
===========================================
- Coverage   86.75%   70.85%   -15.91%     
===========================================
  Files         387     3255     +2868     
  Lines       41713   321430   +279717     
  Branches     6609    28427    +21818     
===========================================
+ Hits        36189   227747   +191558     
- Misses       5409    93501    +88092     
- Partials      115      182       +67

Flag	Coverage Δ
app	`61.55% <78.32%> (?)`
database	`92.54% <100.00%> (+<0.01%)`	⬆️
packages/agent-manager-runtime	`49.69% <ø> (?)`
packages/agent-runtime	`81.08% <ø> (?)`
packages/builtin-tool-lobe-agent	`18.52% <ø> (?)`
packages/context-engine	`84.19% <ø> (?)`
packages/conversation-flow	`91.29% <ø> (?)`
packages/device-gateway-client	`90.51% <ø> (?)`
packages/eval-dataset-parser	`95.15% <ø> (?)`
packages/eval-rubric	`76.11% <ø> (?)`
packages/fetch-sse	`85.57% <ø> (?)`
packages/file-loaders	`87.89% <ø> (ø)`
packages/memory-user-memory	`74.99% <ø> (?)`
packages/model-bank	`99.99% <ø> (?)`
packages/model-runtime	`84.22% <ø> (ø)`
packages/prompts	`72.51% <ø> (ø)`
packages/python-interpreter	`92.90% <ø> (?)`
packages/ssrf-safe-fetch	`0.00% <ø> (?)`
packages/types	`35.38% <ø> (?)`
packages/utils	`84.98% <ø> (?)`
packages/web-crawler	`88.08% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`68.53% <78.57%> (∅)`
Services	`54.77% <36.36%> (∅)`
Server	`71.85% <70.42%> (∅)`
Libs	`57.03% <ø> (∅)`
Utils	`81.71% <100.00%> (-18.29%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Innei · 2026-06-04T06:57:10Z

+export const AGENT_DOCUMENT_CATEGORY = 'document';
+
+export const AGENT_DOCUMENT_FILE_TYPE = 'agent/document';
+export const AGENT_PLAN_FILE_TYPE = 'agent/plan';
+export const CUSTOM_DOCUMENT_FILE_TYPE = 'custom/document';
+
+export const MARKDOWN_DOCUMENT_FILE_TYPES = ['markdown', 'text/markdown', 'text/x-markdown'];
+
+export const EDITOR_DOCUMENT_SOURCE_TYPES = ['agent', 'agent-signal', 'document'];
+


Where are these used? Need to replace other business-use constants.

This comment was translated by Claude.

Original Content

这些在哪里使用的？需要替换其他的业务使用常量

Innei · 2026-06-04T17:15:00Z

@codex review

…flush Add debounced autosave to the non-markdown highlight editor and a StrictMode-safe unmount flush via queueMicrotask, plus a beforeunload guard against dirty buffers.

chatgpt-codex-connector · 2026-06-04T17:20:28Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 4, 2026

sourcery-ai Bot reviewed Jun 4, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Innei commented Jun 4, 2026

View reviewed changes

Innei force-pushed the fix/agent-doc-default-md-render branch from e39ad55 to bd5563b Compare June 4, 2026 06:55

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 4, 2026

Innei commented Jun 4, 2026

View reviewed changes

Innei force-pushed the fix/agent-doc-default-md-render branch from bd5563b to 7cffd94 Compare June 4, 2026 07:17

vercel Bot deployed to Preview June 4, 2026 07:25 View deployment

Innei force-pushed the fix/agent-doc-default-md-render branch from 7cffd94 to edec04a Compare June 4, 2026 08:00

Innei changed the title ~~🐛 fix(agent-documents): default documents to markdown~~ 🐛 fix(agent-documents): render system docs in editor Jun 4, 2026

vercel Bot deployed to Preview June 4, 2026 08:40 View deployment

Innei force-pushed the fix/agent-doc-default-md-render branch from edec04a to b3dc3ef Compare June 4, 2026 15:19

vercel Bot deployed to Preview June 4, 2026 15:38 View deployment

vercel Bot deployed to Preview June 4, 2026 16:30 View deployment

Innei added 2 commits June 5, 2026 01:16

🐛 fix(agent-documents): render system docs in editor

520cfca

✨ feat(agent-documents): autosave highlight editor with safe unmount …

63d7a50

…flush Add debounced autosave to the non-markdown highlight editor and a StrictMode-safe unmount flush via queueMicrotask, plus a beforeunload guard against dirty buffers.

✅ test: fix agent document PR type checks

0eb3f74

Innei force-pushed the fix/agent-doc-default-md-render branch from a726641 to 0eb3f74 Compare June 4, 2026 17:24

vercel Bot deployed to Preview June 4, 2026 18:16 View deployment

Innei merged commit 65ba086 into canary Jun 5, 2026
35 of 37 checks passed

Innei deleted the fix/agent-doc-default-md-render branch June 5, 2026 02:22

This was referenced Jun 9, 2026

🚀 release: 20260610 #15619

Closed

🚀 release: 20260610 #15641

Closed


		export type DocumentRenderMode = { mode: 'editor' } \| { language: string; mode: 'highlight' };

		const EDITOR_DOCUMENT_FILE_TYPES = new Set([

Uh oh!

Conversation

Innei commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

🧪 测试 | Testing

Uh oh!

vercel Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Innei Jun 4, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Innei Jun 4, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Innei Jun 4, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Innei Jun 4, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Innei Jun 4, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Innei commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Innei commented Jun 4, 2026 •

edited

Loading

vercel Bot commented Jun 4, 2026 •

edited

Loading

Innei Jun 4, 2026 •

edited by lobehubbot

Loading

Innei Jun 4, 2026 •

edited by lobehubbot

Loading

Innei Jun 4, 2026 •

edited by lobehubbot

Loading

Innei Jun 4, 2026 •

edited by lobehubbot

Loading

codecov Bot commented Jun 4, 2026 •

edited

Loading

Innei Jun 4, 2026 •

edited by lobehubbot

Loading