Skip to content

chore: remove LOBE-XXX markers from code comments (2026-06-03)#15422

Merged
arvinxx merged 1 commit into
canaryfrom
chore/cleanup-lobe-markers-2026-06-03
Jun 3, 2026
Merged

chore: remove LOBE-XXX markers from code comments (2026-06-03)#15422
arvinxx merged 1 commit into
canaryfrom
chore/cleanup-lobe-markers-2026-06-03

Conversation

@arvinxx

@arvinxx arvinxx commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

Automated daily scan and cleanup of LOBE-XXX format markers from source code comments.

Changes

File Change
packages/model-runtime/src/errors/match.test.ts Removed (LOBE-9913) from test description; the inline comment already explains the ollamacloud error classification context
apps/cli/e2e/fixtures/agent-signal/nightly-review.golden.json Replaced (LOBE-9434) marker with the actual context: execAgent migration converges all agent execution paths (chat, self-iteration, memoryWriter, skillManagement) onto a single entry point

Verification

  • No remaining LOBE-\d+ markers in .ts, .tsx, .js, .jsx, .json source files
  • Affected file count: 2
  • Only comment/text changes — zero functional impact

- match.test.ts: replace (LOBE-9913) marker with inline comment context
- nightly-review.golden.json: replace (LOBE-9434) marker with execAgent migration context
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 3, 2026
@vercel

vercel Bot commented Jun 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Jun 3, 2026 2:18am

Request Review

@dosubot dosubot Bot added the style label Jun 3, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.02%. Comparing base (2eb9e34) to head (91830c2).
⚠️ Report is 2 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff            @@
##           canary   #15422    +/-   ##
========================================
  Coverage   71.02%   71.02%            
========================================
  Files        3212     3212            
  Lines      321285   321285            
  Branches    29240    28293   -947     
========================================
+ Hits       228179   228181     +2     
+ Misses      92931    92929     -2     
  Partials      175      175            
Flag Coverage Δ
app 61.84% <ø> (+<0.01%) ⬆️
database 92.49% <ø> (ø)
packages/agent-runtime 80.48% <ø> (ø)
packages/builtin-tool-lobe-agent 18.52% <ø> (ø)
packages/context-engine 84.17% <ø> (ø)
packages/conversation-flow 91.29% <ø> (ø)
packages/file-loaders 87.89% <ø> (ø)
packages/memory-user-memory 74.99% <ø> (ø)
packages/model-bank 99.99% <ø> (ø)
packages/model-runtime 84.72% <ø> (ø)
packages/prompts 72.49% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/types 35.36% <ø> (ø)
packages/utils 88.69% <ø> (ø)
packages/web-crawler 88.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 68.43% <ø> (ø)
Services 54.58% <ø> (ø)
Server 72.32% <ø> (+<0.01%) ⬆️
Libs 57.01% <ø> (ø)
Utils 81.44% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit 41bccc4 into canary Jun 3, 2026
55 of 56 checks passed
@arvinxx arvinxx deleted the chore/cleanup-lobe-markers-2026-06-03 branch June 3, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant