🐛 fix: bypass audits for headless tool calls#15406
Conversation
|
@cy948 is attempting to deploy a commit to the LobeHub OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
@arvinxx - This PR fixes headless mode tool calling by bypassing runtime audit/approval checks in CLI non-interactive execution, and adjusts 403 error messaging in the local system built-in tool. Please take a look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d694d8ce7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15406 +/- ##
==========================================
+ Coverage 70.84% 70.85% +0.01%
==========================================
Files 3255 3255
Lines 321102 321265 +163
Branches 34998 35011 +13
==========================================
+ Hits 227492 227648 +156
- Misses 93428 93435 +7
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
99318eb to
a2f647f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d61e48b8cc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| type: 'regex', | ||
| }, | ||
| }, | ||
| policy: 'required', |
There was a problem hiding this comment.
Keep credential-read blacklist rules non-overridable
Fresh evidence: the prior always-policy bypass is no longer present, but this commit downgrades credential/privacy reads such as .env from the default always policy to required; GeneralChatAgent now auto-runs global blocks with non-always policy in headless mode (approvalMode === 'headless' && globalPolicy !== 'always'), so an async/headless tool call like cat .env or reading SSH/AWS credentials is executed instead of being rejected. These secret-read blacklist entries need to remain non-overridable or headless must also reject them.
Useful? React with 👍 / 👎.
33270db to
358aa8e
Compare
4e03158 to
209ccc8
Compare
This reverts commit 1d4b534.
209ccc8 to
14a33be
Compare
|
❤️ Great PR @cy948 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
💻 Change Type
🔗 Related Issue
🔀 Description of Change
runCommand）。🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information