chore: remove LOBE-XXX annotations from code comments#15398
Merged
Conversation
Replaced all LOBE-XXX references in comments with descriptive context instead of internal Linear issue markers. As an open-source project, these internal references should not be exposed. Changes: - LOBE-9834 (empty completion): replaced with inline descriptions of the "empty completion" failure mode - LOBE-6587 (task scheduler): replaced with "task scheduler infra" ref - LOBE-6634 (getTaskDetail model/provider): updated TODO description - LOBE-9434 #5/#7 (execAgent migration): removed issue markers 12 files changed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #15398 +/- ##
==========================================
- Coverage 71.17% 71.09% -0.08%
==========================================
Files 3200 3210 +10
Lines 320173 320613 +440
Branches 34056 35001 +945
==========================================
+ Hits 227870 227955 +85
- Misses 92128 92483 +355
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily cleanup of
LOBE-XXXinternal annotations from source code comments. As an open-source project, internal Linear issue markers should not remain in the codebase.Changes
LOBE-9834 - empty completion failure mode (10 references)
Replaced inline references with descriptive context about the "empty completion" failure mode: after a stalled tool loop, the model may give up and emit a blank turn with ~0 output tokens, no text, and no tool calls.
src/server/modules/AgentRuntime/ModelEmptyError.tssrc/server/modules/AgentRuntime/RuntimeExecutors.tssrc/server/modules/AgentRuntime/__tests__/RuntimeExecutors.test.tssrc/server/modules/AgentRuntime/__tests__/llmErrorClassification.test.tssrc/server/modules/AgentRuntime/formatErrorForState.test.tspackages/types/src/agentRuntime.tsLOBE-6587 - task scheduler infra (1 reference)
src/store/task/slices/detail/action.tsLOBE-6634 - getTaskDetail model/provider (1 reference)
src/store/task/selectors/detailSelectors.tsLOBE-9434 #5/#7 - execAgent migration (4 references)
packages/builtin-tool-agent-signal/src/shared/apiNames.tspackages/builtin-tool-agent-signal/src/shared/ExecutionRuntime.tsapps/cli/e2e/agent-signal.e2e.test.tsapps/cli/e2e/fixtures/agent-signal/assertGoldenFinalState.tsFiles changed
12 files changed, 20 insertions(+), 18 deletions(-)