✨ feat(page-share): add document share flow by Innei · Pull Request #15059 · lobehub/lobehub

Innei · 2026-05-21T07:57:10Z

💻 Change Type

🔗 Related Issue

No precise matching GitHub issue found for document/page sharing.

🔀 Description of Change

Add the document_shares database table, schema export, DBML update, and document share model.
Add authenticated document share settings APIs and a public shared document read API.
Add page sharing UI: share button, access popover, public published shell, guest error view, and read-only page viewer.
Add pageShare locale resources and local dev proxy support for shared page routes.

🧪 How to Test

Tested locally
Added/updated tests
No tests needed

Commands run:

bunx vitest run --silent='passed-only' src/spa/router/desktopRouter.sync.test.tsx
cd packages/database && bunx vitest run --silent='passed-only' src/models/__tests__/documentShare.test.ts
git diff --check origin/canary..HEAD

Additional check:

bun run type-check

bun run type-check currently fails on pre-existing repository issues, mainly missing @lobechat/business-model-bank/model-config module declarations and unrelated implicit any errors outside this PR's touched files.

📸 Screenshots / Videos

Before	After
N/A	N/A

📝 Additional Information

Comment and edit access are represented in the UI as coming soon; the current server mutation accepts read-only shared links.

vercel · 2026-05-21T07:57:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lobehub	Ready	Preview, Comment	May 27, 2026 4:54pm

sourcery-ai

We've reviewed this pull request using the Sourcery rules engine

codecov · 2026-05-21T08:10:33Z

Codecov Report

❌ Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.67%. Comparing base (49d191d) to head (b188ada).
⚠️ Report is 7 commits behind head on canary.

Additional details and impacted files

@@            Coverage Diff             @@
##           canary   #15059      +/-   ##
==========================================
- Coverage   70.80%   69.67%   -1.13%     
==========================================
  Files        3159     3091      -68     
  Lines      315826   300125   -15701     
  Branches    28704    25888    -2816     
==========================================
- Hits       223608   209114   -14494     
+ Misses      92049    90842    -1207     
  Partials      169      169

Flag	Coverage Δ
app	`61.66% <23.07%> (-0.01%)`	⬇️
database	`?`
packages/agent-runtime	`80.48% <ø> (ø)`
packages/builtin-tool-lobe-agent	`19.87% <ø> (ø)`
packages/context-engine	`84.13% <ø> (ø)`
packages/conversation-flow	`91.28% <ø> (ø)`
packages/file-loaders	`87.89% <ø> (ø)`
packages/memory-user-memory	`74.99% <ø> (ø)`
packages/model-bank	`99.99% <ø> (ø)`
packages/model-runtime	`83.90% <ø> (ø)`
packages/prompts	`72.67% <ø> (ø)`
packages/python-interpreter	`92.90% <ø> (ø)`
packages/ssrf-safe-fetch	`0.00% <ø> (ø)`
packages/types	`35.03% <0.00%> (-0.02%)`	⬇️
packages/utils	`88.47% <ø> (ø)`
packages/web-crawler	`88.08% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`67.71% <ø> (ø)`
Services	`54.64% <ø> (ø)`
Server	`72.23% <ø> (ø)`
Libs	`56.94% <12.50%> (-0.04%)`	⬇️
Utils	`86.06% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Wait for shared-page probe before mounting authenticated tree to avoid PageAgentProvider stuck in Suspense. - Render guest view inline in (main)/_layout to bypass intermediate Outlet, since outlet context does not propagate across nested layouts. - Whitelist /page/ and /share/ in tRPC 401 handler so unauthenticated guests are not redirected to /signin.

- ShareButton → ActionIcon (consistent with Header siblings), drop SWR pre-fetch. - SharePopover rewritten with createStaticStyles + cssVar tokens; replace custom dropdown with @lobehub/ui/base-ui Select + labelRender/optionRender. - Drop coming-soon comment/edit options, dividers, double padding, hard-coded colors, and dead branches; AccessValue simplified to private/link. - Use copyToClipboard from @lobehub/ui and SHARED_PAGE_PROBE_KEY constant for mutate. - Clean up unused i18n keys.

sourcery-ai

Sorry @Innei, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7edb742fb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-27T12:32:24Z

+    editorData: doc.editorData,
+    fileType: doc.fileType,
+    id: doc.id,
+    metadata: safeMetadata,
+    pages: (doc.pages as unknown[] | null) ?? null,


Avoid exposing editor internals on public shares

For non-owner /page/:id link shares, this public share.getSharedDocument response still includes the raw editorData (and adjacent pages) even though the guest viewer only renders document.content. When a shared page contains editor-only state such as pending diff/review nodes, comments, or other structured metadata, anyone with the link can inspect the network response and read data that is not intended to be part of the published read-only markdown; return these fields only for owners or omit them from the guest payload.

Useful? React with 👍 / 👎.

tjx666 · 2026-05-27T13:02:28Z

+	"updated_at" timestamp with time zone DEFAULT now() NOT NULL
+);
+--> statement-breakpoint
+ALTER TABLE "document_shares" DROP CONSTRAINT IF EXISTS "document_shares_document_id_documents_id_fk";--> statement-breakpoint


Isn't this redundant?

This comment was translated by Claude.

Original Content

这是不是多余的

I'll regenerate it.

This comment was translated by Claude.

Original Content
我重新生成下

arvinxx · 2026-05-29T02:02:07Z

@Innei needs to rebase.

This comment was translated by Claude.

Original Content

@Innei 要 rebase 下了

Innei requested review from arvinxx, nekomeowww and tjx666 as code owners May 21, 2026 07:57

dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature:page labels May 21, 2026

sourcery-ai Bot reviewed May 21, 2026

View reviewed changes

Innei force-pushed the codex/page-share-canary branch from 696aefb to 224e441 Compare May 21, 2026 08:45

Innei marked this pull request as draft May 21, 2026 08:50

vercel Bot deployed to Preview May 21, 2026 09:21 View deployment

vercel Bot deployed to Preview May 21, 2026 13:20 View deployment

dosubot Bot mentioned this pull request May 21, 2026

Failed to resolve module specifier '@lobechat/business-model-bank/model-config' #15077

Closed

8 tasks

Innei added 2 commits May 26, 2026 22:49

✨ feat(page-share): add document share flow

8594e6a

✨ improve page share probe fallback

244a3c4

Innei force-pushed the codex/page-share-canary branch from 2165def to 244a3c4 Compare May 26, 2026 14:57

vercel Bot deployed to Preview May 26, 2026 15:03 View deployment

Innei added 2 commits May 27, 2026 00:35

vercel Bot deployed to Preview May 26, 2026 16:45 View deployment

Innei marked this pull request as ready for review May 27, 2026 12:26

Merge branch 'canary' into codex/page-share-canary

7edb742

sourcery-ai Bot reviewed May 27, 2026

View reviewed changes

vercel Bot deployed to Preview May 27, 2026 12:32 View deployment

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

tjx666 requested changes May 27, 2026

View reviewed changes

🗃️ chore(db): regenerate 0104 document_shares migration with drizzle

623ac50

vercel Bot deployed to Preview May 27, 2026 13:32 View deployment

✨ fix: show shared page title in browser tab for guest routes

b188ada

vercel Bot deployed to Preview May 27, 2026 16:54 View deployment

arvinxx mentioned this pull request May 28, 2026

🔨 feat(db): batch topic usage stats, push tokens, tasks editor_data & document shares migrations #15280

Merged

4 tasks

Innei closed this May 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

✨ feat(page-share): add document share flow#15059

✨ feat(page-share): add document share flow#15059
Innei wants to merge 7 commits into
canaryfrom
codex/page-share-canary

Innei commented May 21, 2026

Uh oh!

vercel Bot commented May 21, 2026 •

edited

Loading

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

codecov Bot commented May 21, 2026 •

edited

Loading

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Uh oh!

tjx666 May 27, 2026 •

edited by lobehubbot

Loading

Uh oh!

Innei May 27, 2026 •

edited by lobehubbot

Loading

Uh oh!

arvinxx commented May 29, 2026 •

edited by lobehubbot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Innei commented May 21, 2026

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

📸 Screenshots / Videos

📝 Additional Information

Uh oh!

vercel Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

Uh oh!

tjx666 May 27, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Innei May 27, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arvinxx commented May 29, 2026 • edited by lobehubbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented May 21, 2026 •

edited

Loading

codecov Bot commented May 21, 2026 •

edited

Loading

tjx666 May 27, 2026 •

edited by lobehubbot

Loading

Innei May 27, 2026 •

edited by lobehubbot

Loading

arvinxx commented May 29, 2026 •

edited by lobehubbot

Loading