💄 style(space-panel): split agent resources into Skills / Documents / Web tabs#15057
Merged
Conversation
…eb tabs Replace the All / Documents / Web filter on the agent Space panel with three dedicated tabs (Skills / Documents / Web, default Skills) and give the Skills tab a folder-style list with expand-to-children rows that matches the heterogeneous agent's skills panel. Extract the row primitive into a shared `SkillsList` component so both panels render the same UI. Skill bundles and their `SKILL.md` index are filtered out of the Documents tree; web items live on their own tab. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15057 +/- ##
==========================================
- Coverage 70.73% 70.73% -0.01%
==========================================
Files 3099 3100 +1
Lines 308317 308381 +64
Branches 32408 27774 -4634
==========================================
+ Hits 218076 218119 +43
- Misses 90078 90099 +21
Partials 163 163
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ebar test `AgentDocumentsGroup` now calls `useNavigate`/`useMatch` at the top level and defaults to the Skills tab, so the parent `AgentWorkingSidebar` test needs a `react-router-dom` mock and the Skills empty-state i18n key. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔀 Description of Change
Reshape the right-side Space panel for non-heterogeneous agents from the old All / Documents / Web pill filter into three dedicated tabs: Skills / Documents / Web (default: Skills). The Skills tab now mirrors the heterogeneous agent's skills surface — each skill bundle is a collapsible row with a count badge, expanding to reveal child files (e.g.
SKILL.md) underneath.Notable bits:
Extract the row primitive into a new shared
SkillsListcomponent undersrc/features/AgentDocumentsExplorer/SkillsList.tsx. Both the heteroSkillsGroup(filesystem-backed) and the non-heteroAgentDocumentsGroup(DB-backed) consume it — no UI duplication.Per-tab data split:
isSkillBundleItem(doc)+ walked children →files[]sourceType !== 'web' && !isManagedSkillItem(doc)sourceType === 'web'Skill bundles +
SKILL.mdindex docs no longer leak into the Documents tree.Drop the dead
viewMode='list' \| 'tree'prop and its tree-grouping branch — the Documents tab always renders the tree now.i18n: replace
workingPanel.resources.filter.allwithworkingPanel.resources.filter.skillsinsrc/locales/default/chat.ts,locales/en-US/chat.json,locales/zh-CN/chat.json. Other locales will regenerate viapnpm i18n.Known follow-up (intentionally deferred): the previous orphan-skill-bundle delete-recovery affordance is gone in this round — the new
SkillsListrow has no inline delete. Orphan bundles are still listed and openable. Will revisit once we decide whether to expose delete via context menu or a per-row slot.🧪 How to Test
Verified all three tabs render correctly against a real agent with 246 documents (2 skill bundles, 42 docs, 198 web). Skills tab expand shows nested
SKILL.md. 11 unit tests inAgentDocumentsGroup.test.tsxpass.bun run type-checkclean.📸 Screenshots / Videos
📝 Additional Information
Scope: non-hetero agent Space panel only. Hetero
SkillsGroupkeeps its existing header but now delegates row rendering to the shared component, so visual parity is preserved.