🎨 Refine Agent Signal receipt cards#14558
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ee2e048fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <MessageContent {...item} /> | ||
| {footerRender} |
There was a problem hiding this comment.
Render receipt footer outside assistant error short-circuit
Placing footerRender inside ChatItem children causes receipts to disappear for assistant messages that surface an error with empty/placeholder content. In ChatItem, the error && isEmptyMessage branch renders only error UI and skips children, so cases like provider failures (message === LOADING_FLAT or blank) will no longer show Agent Signal receipts that previously rendered via endRender at MessageItem level. This is a user-visible regression specifically in error scenarios.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #14558 +/- ##
===========================================
- Coverage 83.05% 68.83% -14.22%
===========================================
Files 437 2632 +2195
Lines 29931 232063 +202132
Branches 5822 28625 +22803
===========================================
+ Hits 24858 159738 +134880
- Misses 4941 72174 +67233
- Partials 132 151 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 864d74294e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const hasEmptyErrorMessage = Boolean( | ||
| errorContent && | ||
| error && | ||
| (message === LOADING_FLAT || !message || String(message).trim() === ''), | ||
| ); |
There was a problem hiding this comment.
Use consistent empty-message check for error footers
footerRender is now injected via both belowMessage and messageExtra, but the guard for belowMessage treats whitespace-only content as empty (String(message).trim() === '') while the error prop still only checks message === LOADING_FLAT || !message || shouldForceShowError. When an assistant message contains only whitespace plus an error, belowMessage is enabled and ChatItem still renders messageExtra, so the receipt footer can render twice and the error-only layout is skipped. This regression comes from the mismatch between the new hasEmptyErrorMessage condition and the existing error condition.
Useful? React with 👍 / 👎.
Summary
PortalResourceCard，并按kind区分 icon 与描述target时才显示Open，并让整张卡可点击；无目标时降级为纯状态卡Testing
bunx vitest run --silent='passed-only' src/features/Conversation/ChatList/components/AgentSignalReceiptList.test.tsxbun run type-check