♻️ refactor(builtin-tools): retire lobe-tools alias and slim lobe-notebook to render-only#14422
Merged
Conversation
…ebook to render-only - Drop the deprecated `'lobe-tools'` identifier alias from the inspector / render registries plus its backward-compat checks in dbMessage selectors and the dev RenderGallery fixtures. - Hoist the only surviving notebook UI (the `createDocument` document card) into `packages/builtin-tools/src/notebook/`, mirroring the github tool layout. Marked the new module `@deprecated` with a ~3-month removal target. - Delete `packages/builtin-tool-notebook/src/client/` entirely and unregister notebook from the inspectors / interventions / placeholders / streamings registries (it can no longer be invoked by the LLM, so those surfaces are dead code). Manifest / executor / ExecutionRuntime stay so legacy tool calls keep resolving. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5bd64f0b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
antd is already provided by the workspace and peered through @lobehub/ui, so listing it explicitly on builtin-tools is noise. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #14422 +/- ##
=========================================
Coverage 68.73% 68.73%
=========================================
Files 2496 2496
Lines 213967 213965 -2
Branches 22456 26081 +3625
=========================================
Hits 147061 147061
+ Misses 66762 66760 -2
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lobe-tools(deprecated alias) — gone. Removed the'lobe-tools'entries from the inspector / render registries, the backward-compat checks indbMessageselectors, and the legacy fixtures in the devRenderGallery. The tooling docs that referenced it have been generalized.lobe-notebook— slimmed to render-only. The only surviving notebook UI (thecreateDocumentdocument card) has been hoisted intopackages/builtin-tools/src/notebook/mirroring thegithubtool layout, and marked@deprecatedwith a ~3-month removal target. The rest ofpackages/builtin-tool-notebook/src/client/(Inspector / Intervention / Placeholder / Streaming / components) has been deleted, and notebook is no longer registered in those four registries.ExecutionRuntimeare intentionally kept so legacy tool calls still resolve in old conversations;lobe-notebookremains a recognized identifier inidentifiers.ts. Addedantdtobuiltin-toolspeer deps because the movedDocumentCarduses antd'sButton.Test plan
bun run type-check— passesbunx vitest runfor affected suites:dbMessageselectors,notebookserver runtime,agentConfigResolver,builtinToolRegistry,streamingExecutor,conversationLifecycle,parseCommands,operation/actions— 244 tests passlobe-notebookcreateDocumentcall and confirm the document card still renders (via DevPanel RenderGallery → "Lobe Notebook → createDocument" fixture)🤖 Generated with Claude Code