Skip to content

✨ feat(notification): add i18n keys for scheduled task failure#14088

Merged
tjx666 merged 6 commits into
canaryfrom
feat/lobe-7756-cron-failure-notification
Apr 27, 2026
Merged

✨ feat(notification): add i18n keys for scheduled task failure#14088
tjx666 merged 6 commits into
canaryfrom
feat/lobe-7756-cron-failure-notification

Conversation

@tjx666

@tjx666 tjx666 commented Apr 23, 2026

Copy link
Copy Markdown
Member

πŸ’» Change Type

  • ✨ feat

πŸ”— Related Issue

Related to LOBE-7756 (cloud-side feature).

πŸ”€ Description of Change

Adds agent_cron_job_failed + agent_cron_job_failed_title i18n keys to en-US and zh-CN notification.json. These keys back the new notification scenario triggered when a user's scheduled agent task fails on the cloud side. Other locales will be filled by the i18n CI pipeline.

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

Cloud-side integration test triggers a failed cron job and verifies the localized notification title/body resolve correctly from these keys.

πŸ“ Additional Information

No functional code in this PR β€” locale-only change.

@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Apr 26, 2026 6:09pm

Request Review

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 23, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@dosubot dosubot Bot added feature:schedule-task Schedule task i18n labels Apr 23, 2026
@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.
βœ… Project coverage is 68.00%. Comparing base (fd9b053) to head (b6b7e0f).
⚠️ Report is 3 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff            @@
##           canary   #14088     +/-   ##
=========================================
  Coverage   67.99%   68.00%             
=========================================
  Files        2259     2260      +1     
  Lines      193630   193666     +36     
  Branches    24142    19448   -4694     
=========================================
+ Hits       131668   131694     +26     
- Misses      61833    61843     +10     
  Partials      129      129             
Flag Coverage Ξ”
app 61.44% <66.66%> (+<0.01%) ⬆️
database 92.04% <ΓΈ> (ΓΈ)
packages/agent-runtime 79.93% <ΓΈ> (ΓΈ)
packages/context-engine 83.25% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.40% <ΓΈ> (ΓΈ)
packages/file-loaders 87.02% <ΓΈ> (ΓΈ)
packages/memory-user-memory 74.74% <ΓΈ> (ΓΈ)
packages/model-bank 99.89% <ΓΈ> (ΓΈ)
packages/model-runtime 84.28% <ΓΈ> (ΓΈ)
packages/prompts 68.17% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 88.41% <ΓΈ> (ΓΈ)
packages/web-crawler 88.66% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 67.20% <ΓΈ> (ΓΈ)
Services 53.36% <ΓΈ> (ΓΈ)
Server 68.19% <59.37%> (-0.01%) ⬇️
Libs 53.30% <ΓΈ> (ΓΈ)
Utils 80.04% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjx666 tjx666 force-pushed the feat/lobe-7756-cron-failure-notification branch from 3e2022f to eab32a9 Compare April 23, 2026 09:47
@tjx666 tjx666 force-pushed the feat/lobe-7756-cron-failure-notification branch from eab32a9 to 34c3ddc Compare April 26, 2026 10:11
@tjx666 tjx666 force-pushed the feat/lobe-7756-cron-failure-notification branch from 34c3ddc to c66c101 Compare April 26, 2026 14:52
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 26, 2026
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 26, 2026
tjx666 added 6 commits April 27, 2026 02:03
Adds en-US and zh-CN locale keys for the new `agent_cron_job_failed` notification scenario surfaced when a scheduled agent task fails.
…lures

Splits the generic scheduled-task failure copy into four user-facing
scenarios (generic, insufficient budget, rate limit, model unavailable)
so the cloud side can surface actionable text per error category
without leaking raw provider / infrastructure messages.
@tjx666 tjx666 force-pushed the feat/lobe-7756-cron-failure-notification branch from c2d9be9 to b6b7e0f Compare April 26, 2026 18:03
@tjx666 tjx666 merged commit 5778185 into canary Apr 27, 2026
35 checks passed
@tjx666 tjx666 deleted the feat/lobe-7756-cron-failure-notification branch April 27, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:schedule-task Schedule task i18n size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant