♻️ refactor: createAgent uses agentModel.create directly#13871
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35d049aa78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The createAgent router was still going through sessionModel.create, which is a legacy path that doesn't pass all agent fields (like agencyConfig) to the agents table. Switch to agentModel.create which directly inserts into the agents table with full field support. - Add CreateAgentSchema in types package for proper input validation - Remove dependency on insertAgentSchema from database package - Remove sessionId from CreateAgentResult Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #13871 +/- ##
=========================================
Coverage 66.76% 66.76%
=========================================
Files 2043 2043
Lines 174032 174015 -17
Branches 17138 20441 +3303
=========================================
- Hits 116184 116174 -10
+ Misses 57724 57717 -7
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
35d049a to
559322d
Compare
agentModel.create directly
Add @deprecated JSDoc tags to the legacy session-based agent creation path (session router, SessionService, SessionModel.create, session store, insertAgentSchema). New code should use agent.createAgent / agentModel.create directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pass input.groupId as sessionGroupId to agentModel.create so that agents created from a sidebar folder are correctly assigned to that group. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove sessionId fallback in AddAgent.tsx and ForkAndChat.tsx - Use z.custom<T>() for agencyConfig and tts in CreateAgentSchema to match agentModel.create parameter types Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createAgentrouter was still going throughsessionModel.create, a legacy path that doesn't pass all agent fields (likeagencyConfig) to the agents tableagentModel.createwhich directly inserts into the agents table with full field supportsessionIdfromCreateAgentResultsince sessions are no longer createdTest plan
🤖 Generated with Claude Code