♻️ refactor: clean up unused sessionStore selectors and slices#13738
Merged
Conversation
Remove dead code from the legacy sessionStore: - Delete `recent` slice (migrated to homeStore) - Delete `homeInput` slice (migrated to homeStore) - Remove unused selectors: currentSessionSafe, hasCustomAgents, defaultSessionsCount, defaultSessionsLimited, getSessionMetaById, currentGroupMeta, getDescription - Update store type, initialState, and tests accordingly Closes LOBE-7018 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13738 +/- ##
==========================================
- Coverage 66.57% 66.56% -0.01%
==========================================
Files 2024 2020 -4
Lines 171360 171152 -208
Branches 20695 20668 -27
==========================================
- Hits 114081 113929 -152
+ Misses 57155 57099 -56
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recentslice from sessionStore (already migrated to homeStore)homeInputslice from sessionStore (already migrated to homeStore)currentSessionSafe,hasCustomAgents,defaultSessionsCount,defaultSessionsLimited,getSessionMetaById,currentGroupMeta,getDescriptionTotal: -879 lines of dead code removed.
Fixes LOBE-7018
Test plan
🤖 Generated with Claude Code