💄 style: show loading state for assistant message during optimistic update#13733
Merged
Conversation
During optimistic update, the assistant message content is "..." but the loading indicator was not shown because isGenerating only checks AI_RUNTIME_OPERATION_TYPES (execAgentRuntime), not sendMessage. Include isCreating state so the loading dots appear immediately when message is sent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13733 +/- ##
==========================================
- Coverage 66.56% 66.56% -0.01%
==========================================
Files 2024 2024
Lines 171319 171319
Branches 16639 16636 -3
==========================================
- Hits 114042 114040 -2
- Misses 57153 57155 +2
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔀 Description of Change
During
sendMessageoptimistic update, the assistant message is created withcontent: LOADING_FLAT("...") but the loading indicator (<ContentLoading>) was not displayed.Root cause:
isMessageGeneratingonly checksAI_RUNTIME_OPERATION_TYPES(execAgentRuntime/execServerAgentRuntime), which doesn't include thesendMessageoperation type. During the gap betweensendMessageandexecAgentRuntime,generatingisfalse, soDisplayContentreturnsnullfor the "..." content.Fix: Also check
isMessageCreating(which covers thesendMessageoperation) alongsideisMessageGeneratingso the loading dots appear immediately when the message is sent.🧪 How to Test
🤖 Generated with Claude Code