chore: bump lucide-react to v1.8.0#13703
Merged
Merged
Conversation
Breaking change: Github icon was removed from lucide-react v1.x (brand icons removed). Replaced with Github from @lobehub/icons in 5 affected files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #13703 +/- ##
=========================================
Coverage 66.67% 66.67%
=========================================
Files 1998 1998
Lines 169045 169047 +2
Branches 20404 16413 -3991
=========================================
+ Hits 112708 112712 +4
+ Misses 56214 56212 -2
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the icon dependency stack by upgrading lucide-react to the v1.x line and addressing the associated breaking change where the GitHub brand icon was removed, by switching affected UI surfaces to use the GitHub icon from @lobehub/icons.
Changes:
- Bump
lucide-reactfrom^0.577.0to^1.8.0. - Replace removed
lucide-reactGitHub icon usage withGithubfrom@lobehub/iconsin the affected components.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Upgrades lucide-react to ^1.8.0. |
| src/features/CommandMenu/MainMenu.tsx | Switches GitHub icon import to @lobehub/icons. |
| src/features/SkillStore/SkillList/AddSkillButton.tsx | Switches GitHub icon import to @lobehub/icons. |
| src/features/SkillStore/SkillList/ImportFromGithubModal.tsx | Switches GitHub icon import to @lobehub/icons. |
| src/routes/(main)/community/features/CreateButton/Inner.tsx | Switches GitHub icon import to @lobehub/icons. |
| src/routes/(main)/home/_layout/Footer/index.tsx | Switches GitHub icon import to @lobehub/icons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lucide-reactfrom^0.577.0to^1.8.0Githubicon removed in v1.x (brand icons removed). Replaced withGithubfrom@lobehub/iconsin 5 affected files.Affected files
package.json— version bumpsrc/features/CommandMenu/MainMenu.tsx— replace Github importsrc/features/SkillStore/SkillList/AddSkillButton.tsx— replace Github importsrc/features/SkillStore/SkillList/ImportFromGithubModal.tsx— replace Github importsrc/routes/(main)/community/features/CreateButton/Inner.tsx— replace Github importsrc/routes/(main)/home/_layout/Footer/index.tsx— replace Github importTest plan
tsc --noEmitpasses with 0 errorsbun run build:spa && bun run build:next)