Skip to content

feat: expose authorUserId in task activity comments#13565

Closed
sudongyuer wants to merge 1 commit into
canaryfrom
fix/task-activity-author-userid
Closed

feat: expose authorUserId in task activity comments#13565
sudongyuer wants to merge 1 commit into
canaryfrom
fix/task-activity-author-userid

Conversation

@sudongyuer

Copy link
Copy Markdown
Collaborator

Summary

  • Add userId field to TaskDetailActivity interface in packages/types/src/task/index.ts
  • Map authorUserId from comment data in src/server/services/task/index.ts getTaskDetail method

This enables the frontend to display user avatar and name for user-authored comments on the task detail page.

Test plan

  • Verify task.detail TRPC response includes userId in comment activities
  • Confirm frontend task detail page can use userId to render user avatar/name

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Apr 4, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: lobehub.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@lobehubbot

Copy link
Copy Markdown
Member

@rdmclin2 - This PR exposes authorUserId in task activity comments (server service + type changes). Please take a look.

@codecov

codecov Bot commented Apr 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.64%. Comparing base (dbdbe16) to head (92da8c6).
⚠️ Report is 8 commits behind head on canary.

❗ There is a different number of reports uploaded between BASE (dbdbe16) and HEAD (92da8c6). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (dbdbe16) HEAD (92da8c6)
packages/file-loaders 2 1
packages/prompts 2 1
packages/model-runtime 2 1
packages/web-crawler 2 1
packages/python-interpreter 2 1
packages/context-engine 2 1
packages/utils 2 1
packages/agent-runtime 2 1
packages/conversation-flow 2 1
packages/ssrf-safe-fetch 2 1
packages/model-bank 2 1
database 2 1
packages/memory-user-memory 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           canary   #13565       +/-   ##
===========================================
- Coverage   86.00%   66.64%   -19.36%     
===========================================
  Files         609     1997     +1388     
  Lines       49045   165686   +116641     
  Branches     7596    16846     +9250     
===========================================
+ Hits        42179   110415    +68236     
- Misses       6742    55147    +48405     
  Partials      124      124               
Flag Coverage Δ
app 58.50% <100.00%> (?)
database 92.57% <ø> (ø)
packages/agent-runtime 88.98% <ø> (ø)
packages/context-engine 85.39% <ø> (ø)
packages/conversation-flow 92.36% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 66.68% <ø> (ø)
packages/model-bank 99.85% <ø> (ø)
packages/model-runtime 84.66% <ø> (ø)
packages/prompts 65.80% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 90.02% <ø> (ø)
packages/web-crawler 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.10% <100.00%> (∅)
Services 51.53% <ø> (∅)
Server 65.98% <100.00%> (∅)
Libs 51.03% <ø> (∅)
Utils 91.01% <ø> (-2.46%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants