Skip to content

💄 style(conversation): align user rich text line height with LexicalRenderer#13312

Merged
Innei merged 1 commit into
lobehub:canaryfrom
Innei:codex/flexbox-lexical-renderer
Mar 26, 2026
Merged

💄 style(conversation): align user rich text line height with LexicalRenderer#13312
Innei merged 1 commit into
lobehub:canaryfrom
Innei:codex/flexbox-lexical-renderer

Conversation

@Innei

@Innei Innei commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

User message rich text uses LexicalRenderer with variant chat. This PR passes a CSS custom property --common-line-height (1.6) via the renderer style prop so wrapped content matches chat typography and avoids overly tight default line-height.

Files: src/features/Conversation/Messages/User/components/RichTextMessage.tsx.

🧪 How to Test

  • Send or open a user message that renders rich text; confirm line spacing looks consistent with surrounding chat copy.

  • Tested locally

  • Added/updated tests

  • No tests needed

📸 Screenshots / Videos

Before After
… …

📝 Additional Information

Branch was reset onto canary and scoped to this UI tweak only (previous PR text described a larger onboarding set that is no longer on this branch).

sourcery-ai[bot]
sourcery-ai Bot reviewed Mar 26, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Innei, your pull request is larger than the review limit of 150000 diff characters

@vercel

vercel Bot commented Mar 26, 2026

Copy link
Copy Markdown

@Innei is attempting to deploy a commit to the LobeHub OSS Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot

lobehubbot commented Mar 26, 2026

Copy link
Copy Markdown
Member

@ONLY-yours @arvinxx @nekomeowww - This PR touches onboarding flow and conversation UI (general feature area), builtin tool calling packages (user-interaction, web-onboarding), and database migrations. Please coordinate review by area.

@Innei Innei force-pushed the codex/flexbox-lexical-renderer branch from f8896f9 to d25e2c6 Compare March 26, 2026 13:43
@Innei Innei changed the title ✨ feat(onboarding): generic user interaction, documents API, and onboarding flow 💄 style(conversation): align user rich text line height with LexicalRenderer Mar 26, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Mar 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8896f9912

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/server/services/toolExecution/serverRuntimes/userInteraction.ts Outdated
Comment thread src/server/services/toolExecution/serverRuntimes/agentDocuments.ts Outdated
Comment thread packages/builtin-tool-user-interaction/src/client/Intervention/AskUserQuestion/index.tsx Outdated
@codecov

codecov Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.76%. Comparing base (0724d8c) to head (d25e2c6).
⚠️ Report is 1 commits behind head on canary.

Additional details and impacted files 
@@           Coverage Diff           @@
##           canary   #13312   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files        1889     1889           
  Lines      151445   151447    +2     
  Branches    17265    17263    -2     
=======================================
+ Hits       101109   101111    +2     
  Misses      50224    50224           
  Partials      112      112
Flag Coverage Δ
app 58.20% <100.00%> (+<0.01%) ⬆️
database 96.64% <ø> (ø)
packages/agent-runtime 89.61% <ø> (ø)
packages/context-engine 83.22% <ø> (ø)
packages/conversation-flow 92.36% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 66.68% <ø> (ø)
packages/model-bank 99.85% <ø> (ø)
packages/model-runtime 84.48% <ø> (ø)
packages/prompts 67.76% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 90.41% <ø> (ø)
packages/web-crawler 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 66.07% <ø> (ø)
Services 49.56% <ø> (ø)
Server 67.35% <ø> (ø)
Libs 51.06% <ø> (ø)
Utils 91.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Innei Innei merged commit 9b7beca into lobehub:canary Mar 26, 2026
20 of 21 checks passed
@lobehubbot

lobehubbot commented Mar 26, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @Innei ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@arvinxx arvinxx Awaiting requested review from arvinxx

@nekomeowww nekomeowww Awaiting requested review from nekomeowww

@tjx666 tjx666 Awaiting requested review from tjx666

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Innei @lobehubbot