Skip to content

🐛 fix(electron): reserve titlebar control space#13204

Merged
Innei merged 2 commits into
canaryfrom
fix-titlebar-overlap
Mar 23, 2026
Merged

🐛 fix(electron): reserve titlebar control space#13204
Innei merged 2 commits into
canaryfrom
fix-titlebar-overlap

Conversation

@Innei

@Innei Innei commented Mar 23, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

N/A

🔀 Description of Change

Reserve right-side title bar space for native Windows controls so the Connection button stays visible.
Extract platform-specific title bar spacing into a shared helper while keeping Linux custom controls behavior unchanged.
Add regression tests for Windows, Linux, and macOS title bar spacing rules.

🧪 How to Test

  • Tested locally

  • Added/updated tests

  • No tests needed

  • bunx vitest run --silent='passed-only' 'src/features/Electron/titlebar/layout.test.ts'

  • bunx eslint 'src/features/Electron/titlebar/TitleBar.tsx' 'src/features/Electron/titlebar/layout.ts' 'src/features/Electron/titlebar/layout.test.ts'

  • bun run type-check

📸 Screenshots / Videos

Before After
N/A N/A

📝 Additional Information

No API or migration changes.

@vercel

vercel Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Mar 23, 2026 1:39pm

Request Review

sourcery-ai[bot]
sourcery-ai Bot reviewed Mar 23, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@lobehubbot

lobehubbot commented Mar 23, 2026

Copy link
Copy Markdown
Member

@ONLY-yours - This is an Electron desktop titlebar fix (reserving Windows native control space). Please take a look.

@codecov

codecov Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.37%. Comparing base (9eca3d2) to head (cf6b340).
⚠️ Report is 5 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary   #13204      +/-   ##
==========================================
+ Coverage   84.35%   87.37%   +3.01%     
==========================================
  Files         375      578     +203     
  Lines       24447    44014   +19567     
  Branches     4740     6852    +2112     
==========================================
+ Hits        20623    38456   +17833     
- Misses       3731     5447    +1716     
- Partials       93      111      +18
Flag Coverage Δ
database 97.89% <ø> (?)
packages/agent-runtime 89.60% <ø> (?)
packages/context-engine 83.53% <ø> (ø)
packages/conversation-flow 92.36% <ø> (?)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 66.68% <ø> (?)
packages/model-bank 99.84% <ø> (?)
packages/model-runtime 84.79% <ø> (+<0.01%) ⬆️
packages/prompts 74.60% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (?)
packages/utils 90.09% <ø> (ø)
packages/web-crawler 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store ∅ <ø> (∅)
Services ∅ <ø> (∅)
Server ∅ <ø> (∅)
Libs ∅ <ø> (∅)
Utils 93.47% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Innei Innei merged commit 6a45414 into canary Mar 23, 2026
33 of 34 checks passed
@Innei Innei deleted the fix-titlebar-overlap branch March 23, 2026 15:29
@lobehubbot

lobehubbot commented Mar 23, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @Innei ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Innei @lobehubbot