🔧 chore(memory): analysis action icon not aligned#13160
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@ONLY-yours - This is a memory feature UI fix (icon alignment). Please take a look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 391fb6f83f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <ActionIcon | ||
| icon={CalendarClockIcon} | ||
| size={DESKTOP_HEADER_ICON_SIZE} | ||
| tooltipProps={{ placement: 'bottom' }} | ||
| onClick={() => setOpen(true)} |
There was a problem hiding this comment.
Restore loading guard on icon-only analysis trigger
The iconOnly path no longer passes loading={loading} to ActionIcon, which regresses the interaction guard during task-state fetches. In MemoryAnalysis, showAction is intentionally true while task data is still undefined, so this button can appear before we know whether an analysis task is already running; without the loading state, users can click through and submit a duplicate extraction request in that window. Please keep the loading binding here to preserve the previous disabled behavior until validation completes.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13160 +/- ##
=========================================
Coverage 74.60% 74.60%
=========================================
Files 1514 1514
Lines 124476 124476
Branches 13790 16459 +2669
=========================================
Hits 92862 92862
Misses 31503 31503
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
❤️ Great PR @nekomeowww ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information