♻️ refactor(store): replace dynamic imports with static imports in actions#13159
Merged
Conversation
…tions Made-with: Cursor
Member
|
@ONLY-yours @nekomeowww - This refactor touches chat plugin actions, file manager, and user memory store. Please coordinate review. |
Member
|
❤️ Great PR @Innei ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
N/A
🔀 Description of Change
Replace redundant dynamic
import()calls with top-level static imports in store actions where the module was already imported (or can be co-imported with existing symbols):dbMessageSelectorsalongsidedisplayMessageSelectors.documentServiceimport from@/services/document.memoryCRUDServicewithuserMemoryServicefrom@/services/userMemory.This keeps behavior the same while simplifying the module graph and avoiding unnecessary async import overhead in these paths.
🧪 How to Test
Smoke: open chat with plugins, rename a knowledge folder, update a memory entry — flows should behave as before.
📸 Screenshots / Videos
N/A (no UI changes)
📝 Additional Information
None
Made with Cursor