🔨 chore: bot architecture upgrade#13096
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Sorry @rdmclin2, your pull request is larger than the review limit of 150000 diff characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #13096 +/- ##
==========================================
- Coverage 74.60% 74.37% -0.24%
==========================================
Files 1489 1503 +14
Lines 122670 123274 +604
Branches 14174 13538 -636
==========================================
+ Hits 91524 91680 +156
- Misses 31036 31484 +448
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6799ad2000
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| platform: 'discord', | ||
| settings: {}, | ||
| }; | ||
| return discord.clientFactory.createClient(config, {}); |
There was a problem hiding this comment.
Provide appUrl to Discord gateway clients
DiscordGatewayClient.start() builds the callback URL from context.appUrl (src/server/services/bot/platforms/discord/client.ts:85), but this new construction path passes an empty runtime context. The cron route here does that, and GatewayManager.createClient() does the same, so queued/direct Discord starts now hand startGatewayListener a relative /api/agent/webhooks/discord/<appId> path instead of a public URL. That leaves the gateway listener without a reachable callback endpoint after startup.
Useful? React with 👍 / 👎.
|
❤️ Great PR @rdmclin2 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information