Skip to content

[FIX] Replace stored atomic volumes with computed ones#227

Merged
lmmentel merged 2 commits intomasterfrom
fix/atomic_volume
Feb 15, 2025
Merged

[FIX] Replace stored atomic volumes with computed ones#227
lmmentel merged 2 commits intomasterfrom
fix/atomic_volume

Conversation

@lmmentel
Copy link
Copy Markdown
Owner

@lmmentel lmmentel commented Feb 15, 2025

Fixes #226

Proposed Changes

  • remove the stored atomic_volume from the elements table since it's missing a reference and might have inconsistent units
  • added atomic_volume hybrid property that computes the property based on atomic weight and density

@lmmentel lmmentel added data Data update bugfix labels Feb 15, 2025
@lmmentel lmmentel merged commit 44ad1b6 into master Feb 15, 2025
20 checks passed
@lmmentel lmmentel deleted the fix/atomic_volume branch February 15, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix data Data update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atomic volumes are missing a reference and cannot be reproduced

1 participant