[FIX] Correct melting and boiling points for Carbon allotropes#214
Merged
[FIX] Correct melting and boiling points for Carbon allotropes#214
Conversation
| @property | ||
| def boiling_point(self) -> Union[float, Dict[str, float]]: | ||
| """Boiling point""" | ||
| def boiling_point(self) -> float | None: |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
| @property | ||
| def melting_point(self) -> Union[float, Dict[str, float]]: | ||
| """Melting point""" | ||
| def melting_point(self) -> float | None: |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212
Proposed Changes
PhaseTransitionfor carbon allotropes (graphite and diamond) since they are not at starndard pressueres.is_sublimation_pointtoPhaseTransitionwhere boiling point is a sublimation pointis_transitiontoPhaseTransitionwhere melting point is a phase transition to the crystalline form.Element.melting_pointandElement.boiling_pointconsistently return either afloatorNoneAfter the changes