Only convert to any on KindAny values#83
Merged
lmittmann merged 2 commits intolmittmann:mainfrom Dec 10, 2024
Merged
Conversation
Indiscriminately calling slog.Value.Any() on the value causes extra allocations for non-any values. Benchmark shows that for each string attribute, an extra 16-byte allocation is incurred. This commit adds a check so Any() is only called on values of KindAny.
148346d to
89712c3
Compare
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indiscriminately calling
slog.Value.Any()on the value causes extra allocations for non-any values. Benchmark shows that for each string attribute, an extra 16-byte allocation is incurred.This commit adds a check so
Any()is only called on values ofKindAny.