[libc++][test] Move format.functions ASCII tests to libcxx/test/libcxx#78661
Merged
StephanTLavavej merged 2 commits intollvm:mainfrom Jan 20, 2024
Merged
[libc++][test] Move format.functions ASCII tests to libcxx/test/libcxx#78661StephanTLavavej merged 2 commits intollvm:mainfrom
libcxx/test/libcxx#78661StephanTLavavej merged 2 commits intollvm:mainfrom
Conversation
They're testing a non-Standard mode.
Member
|
@llvm/pr-subscribers-libcxx Author: Stephan T. Lavavej (StephanTLavavej) ChangesAs @cpplearner explained in microsoft/STL#4328: > libc++'s "ascii" mode (controlled by the Because these files are testing a non-Standard mode, they should be moved from Full diff: https://github.com/llvm/llvm-project/pull/78661.diff 2 Files Affected:
diff --git a/libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/ascii.pass.cpp
diff --git a/libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp b/libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
similarity index 100%
rename from libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
rename to libcxx/test/libcxx/utilities/format/format.functions/escaped_output.ascii.pass.cpp
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
mordante
approved these changes
Jan 19, 2024
Member
mordante
left a comment
There was a problem hiding this comment.
Thanks @cpplearner @StephanTLavavej! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @cpplearner explained in microsoft/STL#4328:
Because these files are testing a non-Standard mode, they should be moved from
libcxx/test/stdtolibcxx/test/libcxx.