Conversation
Member
|
@llvm/pr-subscribers-libcxx Author: Stephan T. Lavavej (StephanTLavavej) Changes@mordante This was introduced by #73395 a couple of days ago. This is causing PR checks to fail, stage3 (generic-no-wide-characters, libcxx-runners-8-set, OFF): Full diff: https://github.com/llvm/llvm-project/pull/74987.diff 1 Files Affected:
diff --git a/libcxx/test/support/concat_macros.h b/libcxx/test/support/concat_macros.h
index bc1306fbdb5331..57c5f5e0632e71 100644
--- a/libcxx/test/support/concat_macros.h
+++ b/libcxx/test/support/concat_macros.h
@@ -80,9 +80,9 @@ template <class InIt, class OutIt>
requires(std::output_iterator<OutIt, const char&> &&
(std::same_as<std::iter_value_t<InIt>, char16_t>
# ifndef TEST_HAS_NO_WIDE_CHARACTERS
- || (std::same_as<std::iter_value_t<InIt>, wchar_t> && sizeof(wchar_t) == 2))
+ || (std::same_as<std::iter_value_t<InIt>, wchar_t> && sizeof(wchar_t) == 2)
# endif
- )
+ ))
OutIt test_transcode(InIt first, InIt last, OutIt out_it) {
while (first != last) {
char32_t value = *first++;
@@ -118,11 +118,11 @@ OutIt test_transcode(InIt first, InIt last, OutIt out_it) {
template <class InIt, class OutIt>
requires(std::output_iterator<OutIt, const char&> &&
- (std::same_as<std::iter_value_t<InIt>, char32_t> ||
+ (std::same_as<std::iter_value_t<InIt>, char32_t>
# ifndef TEST_HAS_NO_WIDE_CHARACTERS
- (std::same_as<std::iter_value_t<InIt>, wchar_t> && sizeof(wchar_t) == 4))
+ || (std::same_as<std::iter_value_t<InIt>, wchar_t> && sizeof(wchar_t) == 4)
# endif
- )
+ ))
OutIt test_transcode(InIt first, InIt last, OutIt out_it) {
while (first != last) {
char32_t value = *first++;
|
mordante
approved these changes
Dec 10, 2023
Member
mordante
left a comment
There was a problem hiding this comment.
Thanks a lot! I just noticed the same in some CI runs. I've no idea how the original patch managed to pass the CI :-/
LGTM!
Member
|
It seems the CI is fixed and the other errors are unrelated. So I'm merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mordante This was introduced by #73395 a couple of days ago.
This is causing PR checks to fail, stage3 (generic-no-wide-characters, libcxx-runners-8-set, OFF):