[CMake][Windows] Turn off lld string tail merging when ASAN is turned on#74207
Merged
[CMake][Windows] Turn off lld string tail merging when ASAN is turned on#74207
Conversation
goussepi
approved these changes
Dec 6, 2023
Collaborator
goussepi
left a comment
There was a problem hiding this comment.
LGTM! Makes sense to me to disable tail merging if it is not compatible with Asan's instrumentation of globals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lld string tail merging interacts badly with ASAN on Windows, as is reported in #62078.
A similar error was found when building LLVM with
-DLLVM_USE_SANITIZER=Address:This is reproducible with the 17.0.3 release: