[test] Fix expected line number in TestRunner.py#73996
Merged
StephanTLavavej merged 1 commit intollvm:mainfrom Nov 30, 2023
Merged
[test] Fix expected line number in TestRunner.py#73996StephanTLavavej merged 1 commit intollvm:mainfrom
TestRunner.py#73996StephanTLavavej merged 1 commit intollvm:mainfrom
Conversation
llvmGH-73541 added lines to llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt so what was previously on line 7 is now on line 12.
Member
|
@llvm/pr-subscribers-testing-tools Author: Stephan T. Lavavej (StephanTLavavej) ChangesMy #73541 added lines to Before: After: This didn't show up in the PR checks, but caused a buildbot failure after merging. Apologies for the build break 🙀 Full diff: https://github.com/llvm/llvm-project/pull/73996.diff 1 Files Affected:
diff --git a/llvm/utils/lit/tests/unit/TestRunner.py b/llvm/utils/lit/tests/unit/TestRunner.py
index f1baf51c02f3a11..09470c7b9386ea8 100644
--- a/llvm/utils/lit/tests/unit/TestRunner.py
+++ b/llvm/utils/lit/tests/unit/TestRunner.py
@@ -132,7 +132,7 @@ def test_commands(self):
value = cmd_parser.getValue()
self.assertEqual(len(value), 2) # there are only two run lines
self.assertEqual(value[0].command.strip(), "%dbg(MY_RUN: at line 4) baz")
- self.assertEqual(value[1].command.strip(), "%dbg(MY_RUN: at line 7) foo bar")
+ self.assertEqual(value[1].command.strip(), "%dbg(MY_RUN: at line 12) foo bar")
def test_boolean(self):
parsers = self.make_parsers()
|
EricWF
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My #73541 added lines to
llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txtso what was previously on line 7 is now on line 12.Before:
llvm-project/llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt
Lines 7 to 8 in 28412d1
After:
llvm-project/llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt
Lines 12 to 13 in 6fb7c2d
This didn't show up in the PR checks, but caused a buildbot failure after merging, https://lab.llvm.org/buildbot/#/builders/139/builds/54597 :
Apologies for the build break 🙀