diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index 17fd80e81a673..8c3d69ee43200 100644 --- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -2640,7 +2640,9 @@ void AsmPrinter::emitGlobalAlias(const Module &M, const GlobalAlias &GA) { return; } - if (GA.hasExternalLinkage() || !MAI.getWeakRefDirective()) + if (MAI.isMachO()) + emitLinkage(&GA, Name); + else if (GA.hasExternalLinkage() || !MAI.getWeakRefDirective()) OutStreamer->emitSymbolAttribute(Name, MCSA_Global); else if (GA.hasWeakLinkage() || GA.hasLinkOnceLinkage()) OutStreamer->emitSymbolAttribute(Name, MCSA_WeakReference); diff --git a/llvm/lib/MC/MachObjectWriter.cpp b/llvm/lib/MC/MachObjectWriter.cpp index b42155d18bf0a..0786ca0e3a83b 100644 --- a/llvm/lib/MC/MachObjectWriter.cpp +++ b/llvm/lib/MC/MachObjectWriter.cpp @@ -443,7 +443,10 @@ void MachObjectWriter::writeNlist(MachSymbolData &MSD, const MCAssembler &Asm) { // The Mach-O streamer uses the lowest 16-bits of the flags for the 'desc' // value. bool EncodeAsAltEntry = IsAlias && OrigSymbol.isAltEntry(); - W.write(Symbol->getEncodedFlags(EncodeAsAltEntry)); + uint16_t Flags = Symbol->getEncodedFlags(EncodeAsAltEntry); + if (IsAlias) + Flags |= OrigSymbol.getEncodedFlags(EncodeAsAltEntry); + W.write(Flags); if (is64Bit()) W.write(Address); else diff --git a/llvm/test/CodeGen/AArch64/macho-weak-alias.ll b/llvm/test/CodeGen/AArch64/macho-weak-alias.ll new file mode 100644 index 0000000000000..a936cea618b38 --- /dev/null +++ b/llvm/test/CodeGen/AArch64/macho-weak-alias.ll @@ -0,0 +1,17 @@ +; RUN: llc -mtriple=aarch64-apple-macosx13.0.0 -filetype=obj %s -o %t.o +; RUN: llvm-nm -m %t.o | FileCheck %s + +define internal void @foo_internal() { + ret void +} + +@foo_default = weak_odr alias void (), ptr @foo_internal +@foo_hidden = weak_odr hidden alias void (), ptr @foo_internal + +define weak_odr hidden void @foo_defined() { + ret void +} + +; CHECK-DAG: weak external _foo_default +; CHECK-DAG: weak private external _foo_hidden +; CHECK-DAG: weak private external _foo_defined