[LLDB][Windows] Initialize read_result#184874
Merged
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Nerixyz (Nerixyz) ChangesWhen I ran As a sidenote: MSVC inserts calls to With LLDB, you get We could improve on the stop reason that's displayed. Full diff: https://github.com/llvm/llvm-project/pull/184874.diff 1 Files Affected:
diff --git a/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp b/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
index c873ce963f535..697c592644cd5 100644
--- a/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
+++ b/lldb/source/Host/windows/ConnectionGenericFileWindows.cpp
@@ -160,8 +160,8 @@ size_t ConnectionGenericFile::Read(void *dst, size_t dst_len,
if (!IsConnected())
return finish(0, eConnectionStatusNoConnection, ERROR_INVALID_HANDLE);
- BOOL read_result;
- DWORD read_error;
+ BOOL read_result = FALSE;
+ DWORD read_error = ERROR_SUCCESS;
if (!m_read_pending) {
m_overlapped.hEvent = m_event_handles[kBytesAvailableEvent];
read_result = ::ReadFile(m_file, dst, dst_len, NULL, &m_overlapped);
|
charles-zablit
approved these changes
Mar 6, 2026
Contributor
charles-zablit
left a comment
There was a problem hiding this comment.
Thanks for fixing this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I ran
lldb -o "b main" -o r, the process crashed atif (!read_result || m_read_pending), becauseread_resultwas uninitialized.As a sidenote: MSVC inserts calls to
_RTC_UninitUsewhich causes a pretty error message when debugging with VS:With LLDB, you get
We could improve on the stop reason that's displayed.