diff --git a/clang/lib/Analysis/ThreadSafetyCommon.cpp b/clang/lib/Analysis/ThreadSafetyCommon.cpp index 8180265cc5ed0..b43a986521f99 100644 --- a/clang/lib/Analysis/ThreadSafetyCommon.cpp +++ b/clang/lib/Analysis/ThreadSafetyCommon.cpp @@ -356,10 +356,10 @@ til::SExpr *SExprBuilder::translate(const Stmt *S, CallingContext *Ctx) { llvm_unreachable("Invalid integer type"); } case Stmt::StringLiteralClass: - return new (Arena) til::LiteralT(cast(S)->getString()); + return new (Arena) til::LiteralT(cast(S)->getBytes()); case Stmt::ObjCStringLiteralClass: return new (Arena) - til::LiteralT(cast(S)->getString()->getString()); + til::LiteralT(cast(S)->getString()->getBytes()); case Stmt::DeclStmtClass: return translateDeclStmt(cast(S), Ctx); diff --git a/clang/test/SemaCXX/warn-thread-safety-analysis.cpp b/clang/test/SemaCXX/warn-thread-safety-analysis.cpp index e57299e93aa48..30d18517c9a19 100644 --- a/clang/test/SemaCXX/warn-thread-safety-analysis.cpp +++ b/clang/test/SemaCXX/warn-thread-safety-analysis.cpp @@ -7770,3 +7770,39 @@ void testLoopConditionalReassignment(Foo *f1, Foo *f2, bool cond) { ptr->mu.Unlock(); // expected-warning{{releasing mutex 'ptr->mu' that was not held}} } // expected-warning{{mutex 'f1->mu' is still held at the end of function}} } // namespace CapabilityAliases + +namespace WideStringLiteral { + +class Foo { + public: + Mutex mu; + Mutex* getMu(const wchar_t* s) { return μ } + Mutex* getMu2(const char16_t* s) { return μ } + Mutex* getMu3(const char32_t* s) { return μ } + + int a GUARDED_BY(getMu(L"abc")); + int b GUARDED_BY(getMu2(u"abc")); + int c GUARDED_BY(getMu3(U"abc")); +}; + +Foo g_foo; + +void test() { + g_foo.getMu(L"abc")->Lock(); + g_foo.a = 0; + g_foo.getMu(L"abc")->Unlock(); +} + +void test2() { + g_foo.getMu2(u"abc")->Lock(); + g_foo.b = 0; + g_foo.getMu2(u"abc")->Unlock(); +} + +void test3() { + g_foo.getMu3(U"abc")->Lock(); + g_foo.c = 0; + g_foo.getMu3(U"abc")->Unlock(); +} + +} // namespace WideStringLiteral