Remove -no-pie case from indirect-goto-relocs.test#133067
Merged
Remove -no-pie case from indirect-goto-relocs.test#133067
Conversation
This test was added in PR: llvm#120267. The -no-pie case in the above mentioned test needs to be removed as subsequent changes have caused it to fail.
Member
|
@llvm/pr-subscribers-bolt Author: Ash Dobrescu (Rin18) ChangesThis test was added in PR: #120267. The -no-pie case in the above mentioned test needs to be removed as subsequent changes have caused it to fail. Full diff: https://github.com/llvm/llvm-project/pull/133067.diff 1 Files Affected:
diff --git a/bolt/test/indirect-goto-relocs.test b/bolt/test/indirect-goto-relocs.test
index 30175dcb0b9c9..25da99b3ad3a9 100644
--- a/bolt/test/indirect-goto-relocs.test
+++ b/bolt/test/indirect-goto-relocs.test
@@ -4,16 +4,7 @@
RUN: %clang %cflags -pie %S/Inputs/indirect_goto.c -o %t.exe -Wl,-q
RUN: llvm-bolt %t.exe -o %t.bolt --print-cfg | FileCheck --check-prefix=CHECK-PIE %s
-RUN: %clang %cflags -no-pie %S/Inputs/indirect_goto.c -o %t.exe -Wl,-q
-RUN: llvm-bolt %t.exe -o %t.bolt --print-cfg | FileCheck --check-prefix=CHECK-NO-PIE %s
-
// Check that BOLT registers extra entry points for dynamic relocations with PIE.
CHECK-PIE: Binary Function "main" after building cfg {
CHECK-PIE: IsMultiEntry: 1
CHECK-PIE: Secondary Entry Points : {{.*}}
-
-// Check that BOLT does not register extra entry points for dynamic relocations
-// without PIE
-CHECK-NO-PIE: Binary Function "main" after building cfg {
-CHECK-NO-PIE-NOT: IsMultiEntry: 1
-CHECK-NO-PIE-NOT: Secondary Entry Points : {{.*}}
|
peterwaller-arm
approved these changes
Mar 26, 2025
Member
peterwaller-arm
left a comment
There was a problem hiding this comment.
Since this is fixing a failing test and have already discussed it, I don't think you need to wait to merge this.
paschalis-mpeis
approved these changes
Mar 26, 2025
Member
There was a problem hiding this comment.
Thanks Ash! LGTM.
That is indeed unrelated to #120267.
PR #120713 added isPop which now returns true here (for the test case), and converts some instructions to tail-calls. As a result handleRelocation processes a few more R_AARCH64_ABS64, which are legit for non-PIE binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was added in PR: #120267. The -no-pie case in the above mentioned test needs to be removed as subsequent changes have caused it to fail.