Backtrace support for flang by dty2 · Pull Request #118179 · llvm/llvm-project

dty2 · 2024-11-30T16:17:02Z

Fixed build failures in old PRs due to missing files

…abort

…delete std::exit in PrintBacktrace

github-actions · 2024-11-30T17:37:18Z

✅ With the latest revision this PR passed the C/C++ code formatter.

tblah · 2024-12-02T10:13:46Z

flang/CMakeLists.txt

+  # function checks
+  find_package(Backtrace)
+  set(HAVE_BACKTRACE ${Backtrace_FOUND})
+  set(BACKTRACE_HEADER ${Backtrace_HEADER})
+


Please could you try putting this in flang/runtime/CMakeLists.txt

tblah · 2024-12-02T10:25:27Z

flang/include/flang/Runtime/stop.h

 // Extensions
 NORETURN void RTNAME(Exit)(int status DEFAULT_VALUE(EXIT_SUCCESS));
 NORETURN void RTNAME(Abort)(NO_ARGUMENTS);
+void RTNAME(Backtrace)(NO_ARGUMENTS);


@jeanPerier pointed out we don't need any of the changes in flang/lib in this case: pointing you at fdate

Suggested change

void RTNAME(Backtrace)(NO_ARGUMENTS);

void FORTRAN_PROCEDURE_NAME(Backtrace)(NO_ARGUMENTS);

With this you shouldn't need any of the frontend changes (flang/lib, and associated header changes).

tblah

Thanks for the updates. Do you still need help to merge?

jeanPerier

nit on the ABORT change, LGTM otherwise, thanks for the update!

jeanPerier · 2024-12-09T13:57:24Z

flang/runtime/stop.cpp

+
 [[noreturn]] void RTNAME(Abort)() {
-  // TODO: Add backtrace call, unless with `-fno-backtrace`.
+  PrintBacktrace();


Could you make that one also conditional on #ifdef HAVE_BACKTRACE I do not think ABORT should crash with "Handle the case when a backtrace is not available\n" on platforms that have no backtrace.

It could lead people to believe that the abort is related to BACKTRACE while it is not.

You are right, thanks for pointing this out.

dty2 · 2024-12-09T16:40:25Z

Thanks for the updates. Do you still need help to merge?

Thank you for your corrections to my questions. I am very grateful. If you think there is no problem, you can merge it.

brad0 · 2025-01-31T10:43:55Z

It looks like the runtime should link against libexecinfo on *BSD's. Backtrace_LIBRARY is filed in. I am not sure of how to go about linking with the runtime in runtime/CMakeLists.txt

FAILED: tools/flang/unittests/Runtime/FlangRuntimeTests
: && /usr/bin/c++ -pipe  -fno-ret-protector -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O2 -Wl,--color-diagnostics    -Wl,--gc-sections  -Xlinker --dependency-file=tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/link.d tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/AccessTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Allocatable.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/ArrayConstructor.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/BufferTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/CharacterTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/CommandTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Complex.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/CrashHandlerFixture.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Derived.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/ExternalIOTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Format.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Inquiry.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/ListInputTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/LogicalFormatTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Matmul.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/MatmulTranspose.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/MiscIntrinsic.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Namelist.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Numeric.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/NumericalFormatTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Pointer.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Ragged.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Random.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Reduction.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/RuntimeCrashTest.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Stop.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Support.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Time.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/TemporaryStack.cpp.o tools/flang/unittests/Runtime/CMakeFiles/FlangRuntimeTests.dir/Transformational.cpp.o -o tools/flang/unittests/Runtime/FlangRuntimeTests  -Wl,-z,origin,-rpath,/home/brad/tmp/llvm-build/lib  lib/libllvm_gtest_main.a  lib/libllvm_gtest.a  -lpthread  lib/libFortranRuntime.a  -lpthread  lib/libFortranDecimal.a  lib/libclang-cpp.so.21.0git  lib/libLLVM.so.21.0git  -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
ld: error: undefined symbol: backtrace
>>> referenced by stop.cpp
>>>               stop.cpp.o:(PrintBacktrace()) in archive lib/libFortranRuntime.a
>>> did you mean: backtrace_
>>> defined in: lib/libFortranRuntime.a(stop.cpp.o)

ld: error: undefined symbol: backtrace_symbols
>>> referenced by stop.cpp
>>>               stop.cpp.o:(PrintBacktrace()) in archive lib/libFortranRuntime.a
c++: error: linker command failed with exit code 1 (use -v to see invocation)

tblah · 2025-01-31T19:17:41Z

Hi @brad0, thanks for looking into this.

I don't have a BSD machine to test but I would guess something like the following would work in flang/runtime/CMakeLists.txt

set(linked_libraries
  FortranDecimal
)
if(CMAKE_SYSTEM_NAME MATCHES ".+BSD")
  list(APPEND linked_libraries "libexecinfo")
endif

# For each usage of add_flang_library use the new list instead of just FortranDecimal:
add_flang_library(FortranRuntime
  ${sources}
  LINK_LIBS
  ${link_libraries}
)

You can find CMake's documentation here (e.g. for list(APPEND )) https://cmake.org/cmake/help/latest/command/list.html#append

brad0 · 2025-02-01T02:15:25Z

@tblah Ok, let me play around with that and see what I can come up with. Thanks.

dty2 and others added 15 commits November 26, 2024 02:18

[flang]Add new intrinsic function backtrace and complete the TODO of …

2d5d310

…abort

commit some suggestions

6b57193

Merge branch 'main' into dty2

0862afd

[flang]Import the header file config.h in flang/runtime/stop.cpp and …

d28136f

…delete std::exit in PrintBacktrace

Merge branch 'dty2' of github.com:dty2/llvm-project into dty2

bf60ffe

Merge branch 'main' into dty2

594c2b3

[flang]Handle the case when a backtrace is not available

ca2ceb5

Merge branch 'dty2' of github.com:dty2/llvm-project into dty2

156e434

Merge branch 'main' into dty2

6c22384

[flang]update format

c2e4cca

Merge branch 'dty2' of github.com:dty2/llvm-project into dty2

0270969

Merge branch 'main' into dty2

d3df426

Merge branch 'main' into dty2

96a861c

[flang]Fix missing file issue

30e5858

[flang]format

d7af048

dty2 mentioned this pull request Nov 30, 2024

Revert "[flang]Add new intrinsic function backtrace and complete the TODO of abort" #117990

Merged

[flang]Solved the build problem in window environment

f2fdf26

[flang]format

6e6c1a5

dty2 mentioned this pull request Nov 30, 2024

[flang]Add new intrinsic function backtrace and complete the TODO of abort #117603

Merged

tblah reviewed Dec 2, 2024

View reviewed changes

tblah requested a review from jeanPerier December 2, 2024 10:21

tblah reviewed Dec 2, 2024

View reviewed changes

dty2 added 2 commits December 8, 2024 11:45

use FORTRAN_PROCEDURE_NAME

1e59e61

update Intrinstic doc

441eede

tblah approved these changes Dec 9, 2024

View reviewed changes

jeanPerier reviewed Dec 9, 2024

View reviewed changes

change ABORT

624a42a

tblah merged commit e8baa79 into llvm:main Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backtrace support for flang#118179

Backtrace support for flang#118179
tblah merged 20 commits intollvm:mainfrom
dty2:dty2

dty2 commented Nov 30, 2024

Uh oh!

github-actions bot commented Nov 30, 2024 •

edited

Loading

Uh oh!

tblah Dec 2, 2024

Uh oh!

tblah Dec 2, 2024

Uh oh!

tblah left a comment

Uh oh!

jeanPerier left a comment

Uh oh!

jeanPerier Dec 9, 2024

Uh oh!

dty2 Dec 9, 2024

Uh oh!

dty2 commented Dec 9, 2024

Uh oh!

brad0 commented Jan 31, 2025

Uh oh!

tblah commented Jan 31, 2025

Uh oh!

brad0 commented Feb 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	void RTNAME(Backtrace)(NO_ARGUMENTS);
	void FORTRAN_PROCEDURE_NAME(Backtrace)(NO_ARGUMENTS);

Conversation

dty2 commented Nov 30, 2024

Uh oh!

github-actions bot commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tblah Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

tblah Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

tblah left a comment

Choose a reason for hiding this comment

Uh oh!

jeanPerier left a comment

Choose a reason for hiding this comment

Uh oh!

jeanPerier Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

dty2 Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

dty2 commented Dec 9, 2024

Uh oh!

brad0 commented Jan 31, 2025

Uh oh!

tblah commented Jan 31, 2025

Uh oh!

brad0 commented Feb 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 30, 2024 •

edited

Loading