[ASan][test] XFAIL stack overflow tests on Linux/sparc64#109773
Merged
[ASan][test] XFAIL stack overflow tests on Linux/sparc64#109773
Conversation
When enabling ASan SPARC testing as per PR llvm#107405, 3 stack overflow tests `FAIL` on Linux/sparc64: ``` AddressSanitizer-sparc-linux :: TestCases/Linux/stack-overflow-recovery-mode.cpp AddressSanitizer-sparc-linux :: TestCases/Linux/stack-overflow-sigbus.cpp AddressSanitizer-sparc-linux :: TestCases/Posix/stack-overflow.cpp AddressSanitizer-sparc-linux-dynamic :: TestCases/Linux/stack-overflow-recovery-mode.cpp AddressSanitizer-sparc-linux-dynamic :: TestCases/Linux/stack-overflow-sigbus.cpp AddressSanitizer-sparc-linux-dynamic :: TestCases/Posix/stack-overflow.cpp ``` However, as detailed in Issue llvm#109771, even a Linux equivalent of the Solaris/sparcv9 fix (PR llvm#109101) doesn't improve the situation. Therefore this patch `XFAIL`s the tests until the root cause can be figured out. Tested on `sparc64-unknown-linux-gnu`, `sparcv9-sun-solaris2.11`, and `x86_64-pc-linux-gnu`.
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Rainer Orth (rorth) ChangesWhen enabling ASan SPARC testing as per PR #107405, 3 stack overflow tests However, as detailed in Issue #109771, even a Linux equivalent of the Solaris/sparcv9 fix (PR #109101) doesn't improve the situation. Therefore this patch Tested on Full diff: https://github.com/llvm/llvm-project/pull/109773.diff 3 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Linux/stack-overflow-recovery-mode.cpp b/compiler-rt/test/asan/TestCases/Linux/stack-overflow-recovery-mode.cpp
index e99665953784ab..461702a0ea7a96 100644
--- a/compiler-rt/test/asan/TestCases/Linux/stack-overflow-recovery-mode.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/stack-overflow-recovery-mode.cpp
@@ -3,6 +3,9 @@
// RUN: %clang_asan -O0 -fsanitize-recover=address %s -o %t
// RUN: %env_asan_opts=halt_on_error=false not %run %t 2>&1 | FileCheck %s
+// Issue #109771
+// XFAIL: target={{sparc.*-.*-linux.*}}
+
#include <assert.h>
#include <unistd.h>
#include <sys/mman.h>
diff --git a/compiler-rt/test/asan/TestCases/Linux/stack-overflow-sigbus.cpp b/compiler-rt/test/asan/TestCases/Linux/stack-overflow-sigbus.cpp
index 8c9599c9f61108..f6c95318238af4 100644
--- a/compiler-rt/test/asan/TestCases/Linux/stack-overflow-sigbus.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/stack-overflow-sigbus.cpp
@@ -2,6 +2,9 @@
// RUN: %clangxx_asan -O0 %s -o %t && %env_asan_opts=use_sigaltstack=1 not %run %t 2>&1 | FileCheck %s
+// Issue #109771
+// XFAIL: target={{sparc.*-.*-linux.*}}
+
#include <assert.h>
#include <stdio.h>
#include <stdlib.h>
diff --git a/compiler-rt/test/asan/TestCases/Posix/stack-overflow.cpp b/compiler-rt/test/asan/TestCases/Posix/stack-overflow.cpp
index 06057250f87599..3d95a4ba273db5 100644
--- a/compiler-rt/test/asan/TestCases/Posix/stack-overflow.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/stack-overflow.cpp
@@ -16,6 +16,9 @@
// RUN: not %run %t 2>&1 | FileCheck %s
// REQUIRES: stable-runtime
+// Issue #109771
+// XFAIL: target={{sparc.*-.*-linux.*}}
+
// UNSUPPORTED: ios
#include <assert.h>
|
vitalybuka
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling ASan SPARC testing as per PR #107405, 3 stack overflow tests
FAILon Linux/sparc64:However, as detailed in Issue #109771, even a Linux equivalent of the Solaris/sparcv9 fix (PR #109101) doesn't improve the situation.
Therefore this patch
XFAILs the tests until the root cause can be figured out.Tested on
sparc64-unknown-linux-gnu,sparcv9-sun-solaris2.11, andx86_64-pc-linux-gnu.