[ASan][test] Fix Posix/coverage-fork.cpp on Solaris#109626
Merged
Conversation
With ASan testing enabled on SPARC as per PR llvm#107405, the ``` AddressSanitizer-sparc-sunos-dynamic :: TestCases/Posix/coverage-fork.cpp ``` test occasionally `FAIL`s on Solaris/sparcv9: ``` compiler-rt/test/asan/TestCases/Posix/coverage-fork.cpp:46:15: error: CHECK-DAG: expected string not found in input // CHECK-DAG: Parent PID: [[ParentPID:[0-9]+]] ^ ``` It turns out that the output for parent and child processes is interleaved like ``` Parent PID: Child PID: 27426 27425 ``` Checking with `truss` shows that the `fprintf`s are implemented as 3 separate `write`s: ``` 28489: write(2, " P a r e n t P I D : ", 12) = 12 28489: write(2, " 2 8 4 8 9", 5) = 5 28489: write(2, "\n", 1) = 1 ``` To avoid this, this patch switches the test to use `snprintf`/`write` to guarantee the output is atomic. Tested on `sparcv9-sun-solaris2.11`, `amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Rainer Orth (rorth) ChangesWith ASan testing enabled on SPARC as per PR #107405, the test occasionally It turns out that the output for parent and child processes is interleaved like Checking with To avoid this, this patch switches the test to use Tested on Full diff: https://github.com/llvm/llvm-project/pull/109626.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Posix/coverage-fork.cpp b/compiler-rt/test/asan/TestCases/Posix/coverage-fork.cpp
index fec9ba081b752c..a8768479de2f67 100644
--- a/compiler-rt/test/asan/TestCases/Posix/coverage-fork.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/coverage-fork.cpp
@@ -26,11 +26,14 @@ void baz() { printf("baz\n"); }
int main(int argc, char **argv) {
pid_t child_pid = fork();
+ char buf[100];
if (child_pid == 0) {
- fprintf(stderr, "Child PID: %d\n", getpid());
+ snprintf(buf, sizeof(buf), "Child PID: %ld\n", (long)getpid());
+ write(2, buf, strlen(buf));
baz();
} else {
- fprintf(stderr, "Parent PID: %d\n", getpid());
+ snprintf(buf, sizeof(buf), "Parent PID: %ld\n", (long)getpid());
+ write(2, buf, strlen(buf));
foo();
bar();
|
vitalybuka
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ASan testing enabled on SPARC as per PR #107405, the
test occasionally
FAILs on Solaris/sparcv9:It turns out that the output for parent and child processes is interleaved like
Checking with
trussshows that thefprintfs are implemented as 3 separatewrites:To avoid this, this patch switches the test to use
snprintf/writeto guarantee the output is atomic.Tested on
sparcv9-sun-solaris2.11,amd64-pc-solaris2.11, andx86_64-pc-linux-gnu.