[WebAssembly] Add indentations to annotations.s#108790
Merged
Conversation
Given that the instructions here are all control flow instructions, adding indentations seem to make it easier to read.
Member
|
@llvm/pr-subscribers-mc @llvm/pr-subscribers-backend-webassembly Author: Heejin Ahn (aheejin) ChangesGiven that the instructions here are all control flow instructions, adding indentations seem to make it easier to read. Full diff: https://github.com/llvm/llvm-project/pull/108790.diff 1 Files Affected:
diff --git a/llvm/test/MC/WebAssembly/annotations.s b/llvm/test/MC/WebAssembly/annotations.s
index 18fd16f2dc687b..b1f97daccccd65 100644
--- a/llvm/test/MC/WebAssembly/annotations.s
+++ b/llvm/test/MC/WebAssembly/annotations.s
@@ -10,28 +10,28 @@ test_annotation:
.functype test_annotation () -> ()
.tagtype __cpp_exception i32
try
- br 0
+ br 0
catch __cpp_exception
- block
- br_if 0
- loop
- br_if 1
- end_loop
- end_block
- try
- rethrow 0
- catch __cpp_exception
- catch_all
- block
- try
- br 0
- try
- delegate 1
- catch_all
- end_try
- end_block
- rethrow 0
- end_try
+ block
+ br_if 0
+ loop
+ br_if 1
+ end_loop
+ end_block
+ try
+ rethrow 0
+ catch __cpp_exception
+ catch_all
+ block
+ try
+ br 0
+ try
+ delegate 1
+ catch_all
+ end_try
+ end_block
+ rethrow 0
+ end_try
end_try
end_function
|
0d0c858 to
cd68474
Compare
dschuff
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the instructions here are all control flow instructions, adding indentations seem to make it easier to read.