[WebAssembly] Rename eh-assembly.s to -legacy.s#108747
Merged
Conversation
The plan was to make `eh-assembly.s` contain both the legacy and the new tests, but the new tests require `--no-type-check` because the type checker for the new EH is in progress. In case this drags on further than expected, this renames the current file to `-legacy.s` in order to follow the current naming scheme in `test/CodeGen/WebAssembly`. After landing this first, `eh-assembly-new.s` in llvm#108668 will be renamed to `eh-assembly.s`.
Member
|
@llvm/pr-subscribers-mc @llvm/pr-subscribers-backend-webassembly Author: Heejin Ahn (aheejin) ChangesThe plan was to make After landing this first, Full diff: https://github.com/llvm/llvm-project/pull/108747.diff 1 Files Affected:
diff --git a/llvm/test/MC/WebAssembly/eh-assembly.s b/llvm/test/MC/WebAssembly/eh-assembly-legacy.s
similarity index 100%
rename from llvm/test/MC/WebAssembly/eh-assembly.s
rename to llvm/test/MC/WebAssembly/eh-assembly-legacy.s
|
dschuff
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan was to make
eh-assembly.scontain both the legacy and the new tests, but the new tests require--no-type-checkbecause the type checker for the new EH is in progress. In case this drags on further than expected, this renames the current file to-legacy.sin order to follow the current naming scheme intest/CodeGen/WebAssembly.After landing this first,
eh-assembly-new.sin #108668 will be renamed toeh-assembly.s.