[libc++] fix array<T, 0> under USE_WRAP_ITER#101156
Merged
strega-nil merged 2 commits intollvm:mainfrom Jul 30, 2024
Merged
Conversation
`array<T, 0>::iterator` was always a pointer even when `_LIBCXX_ABI_USE_WRAP_ITER_IN_STD_ARRAY` was defined. This patch fixes that minor bug. Discovered as part of [llvm#100603][]. [llvm#100603]: llvm#100603
Zingam
reviewed
Jul 30, 2024
all throughout the `array` header.
ldionne
approved these changes
Jul 30, 2024
Member
ldionne
left a comment
There was a problem hiding this comment.
Is that the reason we were introducing new broken test code without noticing?
Either way, thanks for fixing.
Contributor
Author
|
@ldionne exactly :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array<T, 0>::iteratorwas always a pointer even when_LIBCXX_ABI_USE_WRAP_ITER_IN_STD_ARRAYwas defined. This patch fixes that minor bug.Discovered as part of #100603.