Skip to content

Show benchmarking for array combine stuff#187

Closed
elidoran wants to merge 2 commits into
ljharb:masterfrom
elidoran:add-benchmark
Closed

Show benchmarking for array combine stuff#187
elidoran wants to merge 2 commits into
ljharb:masterfrom
elidoran:add-benchmark

Conversation

@elidoran

Copy link
Copy Markdown
Contributor

I made this PR separate from #185 because it's not my intent to add this stuff to master. Instead, I'm providing it just to mess with in its own branch.

Provides a new directory, benchmark/, with a script to benchmark different array combination implementations.

Adds dev dependencies:

  1. benchmark
  2. console.table
  3. comma-number

Run benchmark via:

node benchmark/arraying.js

@ljharb ljharb left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I'm happy to merge this into the project as long as all the important scripts can be run via npm run-script. no big deal either way.

Comment thread benchmark/arraying.js
require('console.table')

var comma = require('comma-number')
, Benchmark = require('benchmark')

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma last, please :-)

@elidoran elidoran mentioned this pull request Dec 22, 2016
@elidoran elidoran closed this Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants