Code Review

This is a clean, focused fix that correctly addresses the YAML parsing issue in the components-independence workflow.

What the fix does

Replacing the heredoc (cat <<'GOEOF') with printf avoids the YAML literal block scalar problem where the heredoc terminator (GOEOF) at column 0 causes GitHub's YAML parser to terminate the block early — meaning the cat command (and potentially following shell commands) gets truncated from the parsed script.

Assessment

Correctness ✓ The fix is functionally equivalent. printf always interprets format-string escape sequences (\n, \t), so the generated main.go will be identical to what the heredoc produced.

Single-quote safety ✓ The Go snippet contains no single quotes, so wrapping in '...' is safe.

Readability concern (minor)

The one-liner is harder to read and maintain. If someone needs to change the Go snippet in the future (e.g., add an import), they have to carefully edit the \n/\t-escaped string. A multi-line printf with line continuations would be easier to work with:

printf '%s\n' \
  'package main' \
  '' \
  'import (' \
  $'\t"fmt"' \
  $'\t"github.com/livetemplate/lvt/components"' \
  ')' \
  '' \
  'func main() {' \
  $'\tfmt.Println(components.Version())' \
  '}' \
  > main.go

That said, for a CI test fixture this simple, the single-line form is acceptable — just a style trade-off.

Overall

The root cause is correctly identified, the fix is minimal and accurate, and the PR description is clear. No functional or security concerns. Good to merge.

PR Review

Summary

This PR fixes a real CI breakage: the heredoc inside a YAML run: | block placed Go code at column 0, which caused the YAML parser to terminate the literal block scalar early. The root cause is correctly identified and the fix is accurate.

.github/workflows/components-independence.yml

The fix is correct. printf always interprets escape sequences for newline and tab, so the generated main.go is byte-for-byte identical to the heredoc output. The Go snippet contains no single quotes, so the single-quote wrapping is safe.

Readability / maintainability nit: The escaped one-liner is hard to read and harder to diff if the test program ever grows. A more maintainable alternative would be to store the file in the repo and copy it in the workflow step. This keeps the Go code as actual Go code (syntax-highlighted, searchable, diffable) and removes any escaping concerns. For a one-off CI test fixture this is a minor point, but worth considering if the snippet ever needs to grow.

Neither this nor any other alternative is required for this fix to land — the one-liner works — flagging for future reference only.

testing/chrome.go

Pure cosmetic alignment of the const block after clientFetchTimeout was previously added without updating column alignment. No logic changes, looks good.

Overall

• Root cause correctly identified
• Fix is minimal and accurate
• No security concerns
• No test coverage gaps (this is a CI config fix)

Good to merge.