Fix: Do not parse empty string as valid value in _convert_bsblan_value#1390
Merged
Fix: Do not parse empty string as valid value in _convert_bsblan_value#1390
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 6 6
Lines 997 997
Branches 139 139
=======================================
Hits 996 996
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Improves robustness of value conversion in the BSB-LAN data model layer by treating empty-string parameter values as inactive (similar to "---"), returning None from _convert_bsblan_value.
Changes:
- Expand inactive-value detection in
_convert_bsblan_valueto include""in addition to"---".
You can also share your feedback on Copilot code review. Take the survey.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor improvement to the
_convert_bsblan_valuefunction insrc/bsblan/models.py. The function now treats both"---"and an empty string as inactive values, returningNonein these cases._convert_bsblan_valuewas expanded to include empty strings ("") in addition to"---", ensuring more robust handling of missing or inactive input values.