Skip to content

fix(openapi): wrong annotation passed to FieldDefinition (DTO)#4158

Merged
provinzkraut merged 3 commits intolitestar-org:mainfrom
mmev:bug/3888-openapi-with-return-dto
May 10, 2025
Merged

fix(openapi): wrong annotation passed to FieldDefinition (DTO)#4158
provinzkraut merged 3 commits intolitestar-org:mainfrom
mmev:bug/3888-openapi-with-return-dto

Conversation

@mmev
Copy link
Copy Markdown
Contributor

@mmev mmev commented May 1, 2025

Description

Fix #3888

Fixed an issue involving incorrect annotations being passed to FieldDefinition when handling Response class.
However, I'm not entirely satisfied with this solution. I'd be happy for any suggestions for alternative approaches.

Closes

@mmev mmev requested review from a team as code owners May 1, 2025 10:14
@github-actions github-actions bot added area/dto This PR involves changes to the DTOs size: small type/bug pr/external Triage Required 🏥 This requires triage labels May 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (312aa07) to head (0ad3e58).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4158   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files         348      348           
  Lines       15889    15890    +1     
  Branches     1755     1755           
=======================================
+ Hits        15630    15631    +1     
  Misses        122      122           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmev mmev requested a review from provinzkraut May 1, 2025 18:22
@mmev mmev force-pushed the bug/3888-openapi-with-return-dto branch from 2eb2875 to 903c80a Compare May 2, 2025 10:14
@provinzkraut provinzkraut force-pushed the bug/3888-openapi-with-return-dto branch from 903c80a to 0ad3e58 Compare May 10, 2025 09:58
@provinzkraut provinzkraut enabled auto-merge (squash) May 10, 2025 09:58
@provinzkraut provinzkraut merged commit a98d958 into litestar-org:main May 10, 2025
28 checks passed
@github-actions
Copy link
Copy Markdown

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: OpenAPI spec blank response schema when using Response object

2 participants