Skip to content

fix(testing): subprocess client raises exc when fails to start#4153

Merged
provinzkraut merged 1 commit intolitestar-org:mainfrom
mmev:bug/4021-testing-subprocess-client-improvements
Apr 29, 2025
Merged

fix(testing): subprocess client raises exc when fails to start#4153
provinzkraut merged 1 commit intolitestar-org:mainfrom
mmev:bug/4021-testing-subprocess-client-improvements

Conversation

@mmev
Copy link
Copy Markdown
Contributor

@mmev mmev commented Apr 29, 2025

Description

Fix #4021

  • Added two new parameters to run_app method: retry_count and retry_timeout
  • run_app now throws StartupError if application doesn't start on time

Closes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (f6a1dbc) to head (4382790).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4153   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         348      348           
  Lines       15846    15857   +11     
  Branches     1749     1751    +2     
=======================================
+ Hits        15588    15599   +11     
  Misses        123      123           
  Partials      135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4153

@provinzkraut provinzkraut merged commit dfeb588 into litestar-org:main Apr 29, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: run_app silently returns a URL to the user even if startup fails

2 participants