fix: misleading error message upon ImportError with --app argument to CLI#4152
Merged
provinzkraut merged 2 commits intolitestar-org:mainfrom Apr 29, 2025
Merged
fix: misleading error message upon ImportError with --app argument to CLI#4152provinzkraut merged 2 commits intolitestar-org:mainfrom
provinzkraut merged 2 commits intolitestar-org:mainfrom
Conversation
62c043b to
83fd10d
Compare
provinzkraut
approved these changes
Apr 29, 2025
Member
provinzkraut
left a comment
There was a problem hiding this comment.
That's a reasonable fix, thanks!
provinzkraut
approved these changes
Apr 29, 2025
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4129
Before this PR, if the
--appCLI option is used, anyImportErrorsthat occur while instantiating the application are assumed to be caused by a bad--appargument. This does not account for cases where the--appoption is actually fine, but theImportErrorarose from inside the applicaiton code, and this results in a misleading error message.This PR adds a check on whether the exception resulted from a failure to import the module named in the
--appoption. If the error arose while attempting some other import, it is not caught. This is consistent with the behaviour that occurs when--appis not used.