Skip to content

fix(typing): Remove usage of private _AnnotatedAlias#4126

Merged
provinzkraut merged 1 commit intomainfrom
remove-annotated-alias
Apr 17, 2025
Merged

fix(typing): Remove usage of private _AnnotatedAlias#4126
provinzkraut merged 1 commit intomainfrom
remove-annotated-alias

Conversation

@provinzkraut
Copy link
Copy Markdown
Member

See python/typing_extensions#586.

We're not using this functionality anymore, so keeping this around just for backwards compatibility.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (72ee19c) to head (7df6e78).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
litestar/utils/predicates.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4126   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         348      348           
  Lines       15841    15841           
  Branches     1749     1749           
=======================================
  Hits        15579    15579           
  Misses        125      125           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4126

Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct thing to do ✅

@provinzkraut provinzkraut merged commit 7f949b3 into main Apr 17, 2025
28 of 29 checks passed
@provinzkraut provinzkraut deleted the remove-annotated-alias branch April 17, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants